fix: postcss-preset-env configuration #2554

dpschen · 2022-10-17T10:59:35Z

dpschen commented

2022-10-17 10:59:35 +00:00

Might be that this has never actually worked…
Since evergreen browsers do support most of the polyfilled apis anyway I guess I never realized this.

Might be that this has never actually worked… Since evergreen browsers do support most of the polyfilled apis anyway I guess I never realized this.

dpschen added 1 commit 2022-10-17 10:59:36 +00:00

continuous-integration/drone/pr Build is passing Details

567bcfe57e

fix: postcss-preset-env configuration

dpschen requested review from konrad 2022-10-17 10:59:40 +00:00

konrad was assigned by dpschen

2022-10-17 10:59:44 +00:00

dpschen reviewed 2022-10-17 11:01:07 +00:00

package.json

						
				@ -104,11 +105,6 @@

				    "wait-on": "6.0.1",

				    "workbox-cli": "6.5.4"

				  },

				  "postcss": {

dpschen commented

2022-10-17 11:01:07 +00:00

Autoprefixer is included by default in postcss-preset-env. So I removed the dedicated configuration.
I also moved the configuration to vite so that package.json is now really only for package related stuff.

Autoprefixer is included by default in postcss-preset-env. So I removed the dedicated configuration. I also moved the configuration to vite so that `package.json` is now really only for package related stuff.

👍 1

frederick commented

2022-10-17 11:02:23 +00:00

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2554-feature-fix-postcss-preset-env--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2554-feature-fix-postcss-preset-env--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.

konrad approved these changes 2022-10-17 11:52:11 +00:00

konrad merged commit b80f82c411 into main

2022-10-17 11:52:29 +00:00

konrad referenced this issue from a commit

2022-10-17 11:52:29 +00:00

fix: postcss-preset-env configuration (#2554)

konrad deleted branch feature/fix-postcss-preset-env

2022-10-17 11:52:29 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers