feat: label store with composition api #2605

Merged
konrad merged 1 commits from dpschen/frontend:feature/pinia-composition-label-store into main 2022-10-31 20:45:45 +00:00
Member
No description provided.
dpschen added the
area/internal-code
label 2022-10-31 13:22:30 +00:00
konrad was assigned by dpschen 2022-10-31 13:22:30 +00:00
dpschen requested review from konrad 2022-10-31 13:22:37 +00:00
dpschen changed title from feat: label store with composition api to wip: feat: label store with composition api 2022-10-31 14:00:26 +00:00
dpschen changed title from wip: feat: label store with composition api to feat: label store with composition api 2022-10-31 14:00:38 +00:00
dpschen changed title from feat: label store with composition api to WIP: feat: label store with composition api 2022-10-31 14:00:42 +00:00
konrad was unassigned by dpschen 2022-10-31 14:27:10 +00:00
dpschen self-assigned this 2022-10-31 14:27:11 +00:00
dpschen force-pushed feature/pinia-composition-label-store from add9aecbe2 to bdd8ab29d5 2022-10-31 14:37:25 +00:00 Compare
Member

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2605-feature-pinia-composition-label---vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2605-feature-pinia-composition-label---vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen changed title from WIP: feat: label store with composition api to feat: label store with composition api 2022-10-31 15:03:08 +00:00
konrad was assigned by dpschen 2022-10-31 15:03:14 +00:00
dpschen removed their assignment 2022-10-31 15:03:14 +00:00
konrad requested changes 2022-10-31 20:28:14 +00:00
konrad left a comment
Owner

Removing a label returns this error:

image

image

Removing a label returns this error: ![image](/attachments/00c05323-785a-4fc1-8b64-30b4be459c69) ![image](/attachments/a415215f-d65e-4cb9-aa6f-0200829c9f6f)
dpschen force-pushed feature/pinia-composition-label-store from bdd8ab29d5 to c56bbcad77 2022-10-31 20:33:07 +00:00 Compare
Author
Member

Should be fixed

Should be fixed
dpschen requested review from konrad 2022-10-31 20:34:09 +00:00
konrad scheduled this pull request to auto merge when all checks succeed 2022-10-31 20:43:47 +00:00
konrad merged commit 1002579173 into main 2022-10-31 20:45:39 +00:00
dpschen deleted branch feature/pinia-composition-label-store 2022-10-31 21:32:50 +00:00
This repo is archived. You cannot comment on pull requests.
No description provided.