feat: lists store with composition api #2606

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2606-feature-pinia-composition-lists---vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.

dpschen changed title from ~~lists store with composition api~~ to feat: lists store with composition api

2022-10-31 15:14:24 +00:00

konrad reviewed 2022-10-31 20:37:29 +00:00

src/stores/lists.ts

						
				@ -81,0 +47,4 @@

						}

					})

					const searchList = computed(() => {

konrad commented

2022-10-31 20:37:29 +00:00

Shouldn't this be a function?

dpschen commented

2022-10-31 20:40:27 +00:00

See #2607 (comment)

See https://kolaente.dev/vikunja/frontend/pulls/2607#issuecomment-38710

👍 1

konrad approved these changes 2022-10-31 20:38:19 +00:00

konrad left a comment

Looks good otherwise.

konrad merged commit 5ae8bace82 into main

2022-10-31 20:41:24 +00:00

konrad referenced this issue from a commit

2022-10-31 20:41:25 +00:00

feat: lists store with composition api (#2606)

konrad deleted branch feature/pinia-composition-lists-store

2022-10-31 20:41:25 +00:00

This repo is archived. You cannot comment on pull requests.

No reviewers

No Label

No Milestone

No project

No Assignees

3 Participants

Due Date

The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#2606