feat: task store with composition api #2610

Merged
konrad merged 1 commits from dpschen/frontend:feature/feat-pinia-composition-task-store into main 2022-10-31 20:22:02 +00:00
Member
No description provided.
dpschen added the
area/internal-code
label 2022-10-31 14:25:42 +00:00
konrad was assigned by dpschen 2022-10-31 14:25:42 +00:00
konrad was unassigned by dpschen 2022-10-31 14:25:49 +00:00
dpschen self-assigned this 2022-10-31 14:25:50 +00:00
dpschen force-pushed feature/feat-pinia-composition-task-store from fda4710ef4 to bb921fbec2 2022-10-31 14:40:48 +00:00 Compare
Member

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2610-feature-feat-pinia-composition-t--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2610-feature-feat-pinia-composition-t--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen force-pushed feature/feat-pinia-composition-task-store from bb921fbec2 to 39d9de3045 2022-10-31 15:06:04 +00:00 Compare
dpschen force-pushed feature/feat-pinia-composition-task-store from 39d9de3045 to 2d3dc6ae8d 2022-10-31 15:26:18 +00:00 Compare
dpschen changed title from WIP: feature/feat-pinia-composition-task-store to feature/feat-pinia-composition-task-store 2022-10-31 15:26:58 +00:00
dpschen requested review from konrad 2022-10-31 15:27:03 +00:00
konrad was assigned by dpschen 2022-10-31 15:27:08 +00:00
dpschen removed their assignment 2022-10-31 15:27:09 +00:00
dpschen changed title from feature/feat-pinia-composition-task-store to feat: task store with composition api 2022-10-31 15:27:32 +00:00
konrad reviewed 2022-10-31 20:12:12 +00:00
@ -303,0 +222,4 @@
if (t.task === null) {
// Don't try further adding a label if the task is not in kanban
// Usually this means the kanban board hasn't been accessed until now.
// Vuex seems to have its difficulties with that, so we just log the error and fail silently.

Might be worth checking if that's still a problem.

Might be worth checking if that's still a problem.
konrad merged commit 839d331bf5 into main 2022-10-31 20:22:02 +00:00
konrad deleted branch feature/feat-pinia-composition-task-store 2022-10-31 20:22:02 +00:00
This repo is archived. You cannot comment on pull requests.
No description provided.