vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: sticky action buttons #2622

Merged
konrad merged 1 commits from dpschen/frontend:feature/feat-sticky-action-buttons into main 2022-11-04 13:49:30 +00:00
Conversation 3 Commits 1 Files Changed 3 +59 -26
dpschen commented 2022-11-01 18:23:56 +00:00
Member
Copy Link

There is a lot that needs to be changed for TaskDetailView. I only added this because I was annoyed and it's a super simple quick-win in the end it was more complex then anticipated…

There is a lot that needs to be changed for TaskDetailView. I only added this because I was annoyed and ~~it's a super simple quick-win~~ in the end it was more complex then anticipated…
dpschen added the
kind/feature
 label 2022-11-01 18:23:56 +00:00
konrad was assigned by dpschen 2022-11-01 18:23:56 +00:00
dpschen requested review from konrad 2022-11-01 18:24:01 +00:00
frederick commented 2022-11-01 18:27:16 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2622-feature-feat-sticky-action-butto--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2622-feature-feat-sticky-action-butto--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
konrad requested changes 2022-11-01 18:37:17 +00:00
konrad left a comment
Owner

Please add more spacing to the top so that all buttons are usable:

image

Please add more spacing to the top so that all buttons are usable: ![image](/attachments/54ae5661-5da7-4bf3-8636-7912d83e18fd)
image.png
76 KiB
dpschen commented 2022-11-01 18:54:25 +00:00
Author
Member
Copy Link

Ohh yes. I only tested the modal version. Shouldn't have said super simple 

Ohh yes. I only tested the modal version. Shouldn't have said super simple 
😆 1
dpschen force-pushed feature/feat-sticky-action-buttons from e0a10761c3 to c532d2980a 2022-11-04 12:04:56 +00:00 Compare
dpschen requested review from konrad 2022-11-04 12:07:07 +00:00
konrad requested changes 2022-11-04 12:11:14 +00:00
konrad left a comment
Owner

Please fix the lint errors.

Please fix the lint errors.
konrad approved these changes 2022-11-04 12:17:37 +00:00
konrad left a comment
Owner

Ready to merge apart from the lint issues.

Ready to merge apart from the lint issues.
dpschen force-pushed feature/feat-sticky-action-buttons from c532d2980a to 25304cd9c1 2022-11-04 12:18:13 +00:00 Compare
dpschen requested review from konrad 2022-11-04 12:18:49 +00:00
dpschen scheduled this pull request to auto merge when all checks succeed 2022-11-04 12:19:03 +00:00
dpschen commented 2022-11-04 13:48:57 +00:00
Author
Member
Copy Link

Okay, you need to reaprrove. I accidentialy clicked the review again button.

Okay, you need to reaprrove. I accidentialy clicked the review again button.
konrad merged commit f4bc2b94f0 into main 2022-11-04 13:49:30 +00:00
konrad deleted branch feature/feat-sticky-action-buttons 2022-11-04 13:49:30 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#2622
No description provided.
Delete Branch "dpschen/frontend:feature/feat-sticky-action-buttons"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?