fix(deps): update dependency @fortawesome/vue-fontawesome to v3.0.2 #2654

Merged
dpschen merged 1 commits from renovate/font-awesome into main 2022-11-09 11:42:26 +00:00
Member

This PR contains the following updates:

Package Type Update Change
@fortawesome/vue-fontawesome dependencies patch 3.0.1 -> 3.0.2

Release Notes

FortAwesome/vue-fontawesome

v3.0.2

Compare Source

Changed
  • Vue 3 Composition API TypeScript support (github issue #276)
  • Updated README.md with a spelling correction, linter fixes, and new contributor
  • Updated icon example in App.vue to use fixed-width rather than full-width
Added
  • Missing tests

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, click this checkbox.

This PR has been generated by Renovate Bot.

This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@fortawesome/vue-fontawesome](https://github.com/FortAwesome/vue-fontawesome) | dependencies | patch | [`3.0.1` -> `3.0.2`](https://renovatebot.com/diffs/npm/@fortawesome%2fvue-fontawesome/3.0.1/3.0.2) | --- ### Release Notes <details> <summary>FortAwesome/vue-fontawesome</summary> ### [`v3.0.2`](https://github.com/FortAwesome/vue-fontawesome/releases/tag/3.0.2) [Compare Source](https://github.com/FortAwesome/vue-fontawesome/compare/3.0.1...3.0.2) ##### Changed - Vue 3 Composition API TypeScript support (github issue #[276](https://github.com/FortAwesome/vue-fontawesome/issues/276)) - Updated README.md with a spelling correction, linter fixes, and new contributor - Updated icon example in App.vue to use `fixed-width` rather than `full-width` ##### Added - Missing tests </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox. --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yNDAuMiIsInVwZGF0ZWRJblZlciI6IjMyLjI0MC4yIn0=-->
renovate added the
dependencies
label 2022-11-07 23:03:53 +00:00
Member

Hi renovate!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2654-renovate-font-awesome--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi renovate! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2654-renovate-font-awesome--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
Owner

@dpschen This release adds TypeScript types, should we remove our types in favor of theirs?

@dpschen This release adds TypeScript types, should we remove our types in favor of theirs?
Member

@dpschen This release adds TypeScript types, should we remove our types in favor of theirs?

Will check

> @dpschen This release adds TypeScript types, should we remove our types in favor of theirs? Will check
Member
Types seem still really bad. See: https://kolaente.dev/vikunja/frontend/src/branch/main/src/types/vue-fontawesome.ts vs https://github.com/FortAwesome/vue-fontawesome/blob/3.x/index.d.ts
dpschen force-pushed renovate/font-awesome from 6b62754d62 to e6eaac1b46 2022-11-09 11:31:22 +00:00 Compare
dpschen approved these changes 2022-11-09 11:31:44 +00:00
Member

As said the types are still not good, but I also couldn't find probelms when used together with our type additions => Seems still fine to merge.

As said the types are still not good, but I also couldn't find probelms when used together with our type additions => Seems still fine to merge.
dpschen scheduled this pull request to auto merge when all checks succeed 2022-11-09 11:32:29 +00:00
dpschen merged commit e6eaac1b46 into main 2022-11-09 11:42:26 +00:00
This repo is archived. You cannot comment on pull requests.
No description provided.