feature/feat-filters-script-setup3 #2671
No reviewers
Labels
No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
No Milestone
No project
No Assignees
3 Participants
Due Date
No due date set.
Dependencies
No dependencies set.
Reference: vikunja/frontend#2671
Loading…
Reference in New Issue
No description provided.
Delete Branch "dpschen/frontend:feature/feat-filters-script-setup3"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Might even be the 4th try.
I needed a working basis. This seems to work.
On basis of this I will apply the other filter improvements.
As a sideeffect even the clear filters button seems to have improved (it's still not always correct).
Hi dpschen!
Thank you for creating a PR!
I've deployed the changes of this PR on a preview environment under this URL: https://2671-feature-feat-filters-script-setu--vikunja-frontend-preview.netlify.app
You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.
Have a nice day!
When I change any filter value it sends 4 requests to show the tasks. That's probably due to the
change
function being triggered multiple times.I feel like I've seen this before, not sure if this is a bug introduced by the changes here.
Oh that's interesting. Good catch! I wanted to remove that change function either way. Mhh checking how I can do that without changing how everything works… I mean that was the whole point of this branch.
This seems to be the case on try already:
Which means that this pull request ist still valid as it is, since the target was only to conver to script setup.
Sending 4 requests obviously isn't good. I would still want to fix that after this (meaning soon), because it has nothing to do with script setup.
🔥 if I remember correctly this was the last component missing for our script setup transition!!
Per https://my.vikunja.cloud/tasks/15110 it was!