feature/feat-filters-script-setup3 #2671

Merged
konrad merged 2 commits from dpschen/frontend:feature/feat-filters-script-setup3 into main 2022-11-12 10:43:29 +00:00
Member

Might even be the 4th try.

I needed a working basis. This seems to work.
On basis of this I will apply the other filter improvements.

As a sideeffect even the clear filters button seems to have improved (it's still not always correct).

Might even be the 4th try. I needed a working basis. This seems to work. On basis of this I will apply the other filter improvements. As a sideeffect even the clear filters button seems to have improved (it's still not always correct).
dpschen added 2 commits 2022-11-10 16:18:36 +00:00
dpschen requested review from konrad 2022-11-10 16:18:42 +00:00
konrad was assigned by dpschen 2022-11-10 16:18:44 +00:00
dpschen added the
area/internal-code
label 2022-11-10 16:18:51 +00:00
Member

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2671-feature-feat-filters-script-setu--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2671-feature-feat-filters-script-setu--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
Owner

When I change any filter value it sends 4 requests to show the tasks. That's probably due to the change function being triggered multiple times.

I feel like I've seen this before, not sure if this is a bug introduced by the changes here.

When I change any filter value it sends 4 requests to show the tasks. That's probably due to the `change` function being triggered multiple times. I feel like I've seen this before, not sure if this is a bug introduced by the changes here.
Author
Member

Oh that's interesting. Good catch! I wanted to remove that change function either way. Mhh checking how I can do that without changing how everything works… I mean that was the whole point of this branch.

Oh that's interesting. Good catch! I wanted to remove that change function either way. Mhh checking how I can do that without changing how everything works… I mean that was the whole point of this branch.
Author
Member

This seems to be the case on try already:

image

Which means that this pull request ist still valid as it is, since the target was only to conver to script setup.

Sending 4 requests obviously isn't good. I would still want to fix that after this (meaning soon), because it has nothing to do with script setup.

This seems to be the case on try already: ![image](/attachments/3797760d-895f-474f-8c9a-5bc6ef2c1804) Which means that this pull request ist still valid as it is, since the target was only to conver to script setup. Sending 4 requests obviously isn't good. I would still want to fix that after this (meaning soon), because it has nothing to do with script setup.
konrad merged commit 4a550da6a6 into main 2022-11-12 10:43:28 +00:00
Author
Member

🔥 if I remember correctly this was the last component missing for our script setup transition!!

🔥 if I remember correctly this was the last component missing for our script setup transition!!
dpschen deleted branch feature/feat-filters-script-setup3 2022-11-12 13:47:48 +00:00
Owner
Per https://my.vikunja.cloud/tasks/15110 it was!
This repo is archived. You cannot comment on pull requests.
No description provided.