vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feature/move-transition-in-component #2694

Merged
konrad merged 3 commits from dpschen/frontend:feature/move-transition-in-component into main 2022-11-16 14:36:19 +00:00
Conversation 6 Commits 3 Files Changed 31 +393 -396
dpschen commented 2022-11-12 18:34:00 +00:00
Member
Copy Link

In theory this should also fix quite a few modal transition issues.

Doesn't fix all the issues. But makes fixing them easier in the future.

~~In theory this should also fix quite a few modal transition issues.~~ Doesn't fix all the issues. But makes fixing them easier in the future.
dpschen added the
kind/feature
area/internal-code
 labels 2022-11-12 18:34:00 +00:00
konrad was assigned by dpschen 2022-11-12 18:34:00 +00:00
dpschen added 2 commits 2022-11-12 18:34:01 +00:00
dpschen requested review from konrad 2022-11-12 18:34:06 +00:00
frederick commented 2022-11-12 18:38:56 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2694-feature-move-transition-in-compo--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2694-feature-move-transition-in-compo--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen changed title from feature/move-transition-in-component to WIP: feature/move-transition-in-component 2022-11-12 19:13:54 +00:00
konrad commented 2022-11-12 20:47:04 +00:00
Owner
Copy Link

Looks like this broke pretty much all frontend tests: https://dashboard.cypress.io/projects/181c7x/runs/3046/overview

Looks like this broke pretty much all frontend tests: https://dashboard.cypress.io/projects/181c7x/runs/3046/overview
konrad commented 2022-11-12 20:47:52 +00:00
Owner
Copy Link

juding from the test results in Cypress' dashboard it looks like the modal never disappears.

juding from the test results in Cypress' dashboard it looks like the modal never disappears.
dpschen commented 2022-11-13 12:21:59 +00:00
Author
Member
Copy Link

Looks like this broke pretty much all frontend tests: https://dashboard.cypress.io/projects/181c7x/runs/3046/overview

Yes, I'm not done here yet :)

> Looks like this broke pretty much all frontend tests: https://dashboard.cypress.io/projects/181c7x/runs/3046/overview Yes, I'm not done here yet :)
👍 1
dpschen force-pushed feature/move-transition-in-component from 301825d45e to 8c44ed83e6 2022-11-14 21:09:08 +00:00 Compare
dpschen changed title from WIP: feature/move-transition-in-component to feature/move-transition-in-component 2022-11-15 17:19:57 +00:00
dpschen commented 2022-11-15 17:20:07 +00:00
Author
Member
Copy Link

This should work now

This should work now
konrad approved these changes 2022-11-16 14:36:00 +00:00
konrad left a comment
Owner

Awesome, the modal fade in seems to work smoothly now!

Awesome, the modal fade in seems to work smoothly now!
🎉 1
konrad merged commit 77ff0aa256 into main 2022-11-16 14:36:19 +00:00
konrad deleted branch feature/move-transition-in-component 2022-11-16 14:36:19 +00:00
dpschen commented 2022-11-16 16:31:59 +00:00
Author
Member
Copy Link

Awesome, the modal fade in seems to work smoothly now!

There are still some issues, but much better than before.

> Awesome, the modal fade in seems to work smoothly now! There are still some issues, but much better than before.
👍 1
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#2694
No description provided.
Delete Branch "dpschen/frontend:feature/move-transition-in-component"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?