feat: rename lists to projects #2697
|
@ -42,7 +42,7 @@ const SORT_BY_DEFAULT = {
|
||||||
}
|
}
|
||||||
|
|
||||||
/**
|
/**
|
||||||
* This mixin provides a base set of methods and properties to get tasks on a project.
|
* This mixin provides a base set of methods and properties to get tasks.
|
||||||
konrad marked this conversation as resolved
Outdated
|
|||||||
*/
|
*/
|
||||||
export function useTaskList(projectId, sortByDefault = SORT_BY_DEFAULT) {
|
export function useTaskList(projectId, sortByDefault = SORT_BY_DEFAULT) {
|
||||||
konrad marked this conversation as resolved
dpschen
commented
I use I use `list` usually as a suffix to indicate that there are multiple items. E.g. if a have a component with a for loop I will add a `foobar__list` to the wrapper with the `v-for` and a `foobar__item` to the individual items inside. This is the logic used for naming this. Maybe `collection` would be a better wording now, since after the merge of this branch 'list' will mostly refer to the layout not the data format.
konrad
commented
ohh so ohh so `listId` here is not the id of the list but some identifier about the current "list of things"? The way it gets used in getAllTasksParams` looked like a (now) project id.
dpschen
commented
Tbh I'm unsure about this. I have also adjusted this massively and don't rembember the original function as it is here very well. Can we keep this for now as useTaskList? I could still change the name later (maybe just > ohh so listId here is not the id of the list but some identifier about the current "list of things"? The way it gets used in getAllTasksParams` looked like a (now) project id.
Tbh I'm unsure about this. I have also adjusted this massively and don't rembember the original function as it is here very well.
Can we keep this for now as useTaskList? I could still change the name later (maybe just `useProject`?).
konrad
commented
so leaving it as it is now? The name of the function did not change, only the parameter. so leaving it as it is now? The name of the function did not change, only the parameter.
dpschen
commented
Yes, that's what I meant :) Yes, that's what I meant :)
|
|||||||
const params = ref({...getDefaultParams()})
|
const params = ref({...getDefaultParams()})
|
||||||
|
|
Maybe we can write here now:
This mixin provides a base set of methods and properties to get tasks.
Done