vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feature/improve-navigation-style-scoping #2711

Merged
dpschen merged 6 commits from dpschen/frontend:feature/improve-navigation-style-scoping into main 2022-11-18 15:49:40 +00:00
Conversation 4 Commits 6 Files Changed 5 +264 -245
dpschen commented 2022-11-15 17:33:41 +00:00
Member
Copy Link
No description provided.
dpschen added the
changes requested
area/internal-code
 labels 2022-11-15 17:33:42 +00:00
frederick commented 2022-11-15 17:38:53 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2711-feature-improve-navigation-style--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2711-feature-improve-navigation-style--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
dpschen changed title from WIP: feature/improve-navigation-style-scoping to feature/improve-navigation-style-scoping 2022-11-15 18:55:14 +00:00
dpschen requested review from konrad 2022-11-15 18:55:20 +00:00
konrad requested changes 2022-11-16 14:30:58 +00:00
konrad left a comment
Owner

If a list has a color it's not shown directly after changing it:

image

And it looks like this has moved the list settings dropdown:

image

If a list has a color it's not shown directly after changing it: ![image](/attachments/736bfcb3-cee5-42d7-962f-84cd0c7d8030) And it looks like this has moved the list settings dropdown: ![image](/attachments/b30951d3-fdf4-4b94-96a2-2ee82a4e0518)
image.png
5.7 KiB
image.png
6.9 KiB
dpschen commented 2022-11-16 16:33:41 +00:00
Author
Member
Copy Link

If a list has a color it's not shown directly after changing it [...]

will check

> If a list has a color it's not shown directly after changing it [...] will check
dpschen commented 2022-11-18 12:36:11 +00:00
Author
Member
Copy Link

If a list has a color it's not shown directly after changing it

This is definitively a bug, but is not caused by this branch. Is also happening on try. I did fix the offsetted trigger button though.

> If a list has a color it's not shown directly after changing it This is definitively a bug, but is not caused by this branch. Is also happening on try. I did fix the offsetted trigger button though.
dpschen force-pushed feature/improve-navigation-style-scoping from 4bba373fd4 to ac4924af55 2022-11-18 12:59:54 +00:00 Compare
dpschen commented 2022-11-18 13:00:39 +00:00
Author
Member
Copy Link

Fixed the handle offset. There were also some issues with the color of the icons that I fixed.

Fixed the handle offset. There were also some issues with the color of the icons that I fixed.
dpschen requested review from konrad 2022-11-18 13:00:50 +00:00
konrad reviewed 2022-11-18 13:31:35 +00:00
src/components/home/navigation.vue Outdated
@ -131,1 +131,3 @@
<list-settings-dropdown :list="l" v-if="l.id > 0"/>
<list-settings-dropdown class="menu-list-dropdown" :list="l" v-if="l.id > 0">
<template #trigger="{toggleOpen}">
<BaseButton class="menu-list-dropdown-trigger" @click="toggleOpen">
konrad commented 2022-11-18 13:31:35 +00:00
Owner

The cypress tests expect this class to be called .namespace-container .menu.namespaces-lists .menu-list li:first-child .dropdown .dropdown-trigger but it's not. Can you update the test class?

The cypress tests expect this class to be called `.namespace-container .menu.namespaces-lists .menu-list li:first-child .dropdown .dropdown-trigger` but it's not. Can you update the test class?
dpschen marked this conversation as resolved
konrad approved these changes 2022-11-18 13:32:53 +00:00
konrad left a comment
Owner

Ready to merge once tests pass.

Ready to merge once tests pass.
dpschen force-pushed feature/improve-navigation-style-scoping from ac4924af55 to 4a072b460c 2022-11-18 14:20:11 +00:00 Compare
dpschen force-pushed feature/improve-navigation-style-scoping from 4a072b460c to 15da107135 2022-11-18 14:37:27 +00:00 Compare
dpschen merged commit 74ad98de68 into main 2022-11-18 15:49:40 +00:00
dpschen deleted branch feature/improve-navigation-style-scoping 2022-11-18 15:49:40 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#2711
No description provided.
Delete Branch "dpschen/frontend:feature/improve-navigation-style-scoping"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?