vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: improve loadTask logic #2715

Merged
konrad merged 1 commits from dpschen/frontend:feature/improve-task-loading-logic into main 2022-11-17 15:31:23 +00:00
Conversation 2 Commits 1 Files Changed 1 +6 -7
dpschen commented 2022-11-15 19:06:12 +00:00
Member
Copy Link
No description provided.
dpschen added the
area/internal-code
 label 2022-11-15 19:06:12 +00:00
konrad was assigned by dpschen 2022-11-15 19:06:12 +00:00
dpschen requested review from konrad 2022-11-15 19:06:17 +00:00
dpschen force-pushed feature/improve-task-loading-logic from d87bf8d4fc to 239c9bdbfe 2022-11-15 21:01:25 +00:00 Compare
frederick commented 2022-11-15 21:07:22 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2715-feature-improve-task-loading-log--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2715-feature-improve-task-loading-log--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
konrad requested changes 2022-11-16 14:26:04 +00:00
konrad left a comment
Owner

Looks like this breaks the task detail view:

image

Looks like this breaks the task detail view: ![image](/attachments/10704b58-287d-4952-a478-d441cc540844)
image.png
86 KiB
dpschen commented 2022-11-16 16:36:34 +00:00
Author
Member
Copy Link

Looks like this breaks the task detail view:

image

missed the immediate: true

> Looks like this breaks the task detail view: > > ![image](/attachments/10704b58-287d-4952-a478-d441cc540844) missed the `immediate: true`
dpschen force-pushed feature/improve-task-loading-logic from 239c9bdbfe to b11d3de8da 2022-11-17 11:21:52 +00:00 Compare
dpschen requested review from konrad 2022-11-17 11:44:57 +00:00
konrad merged commit 8ef309243d into main 2022-11-17 15:31:23 +00:00
konrad deleted branch feature/improve-task-loading-logic 2022-11-17 15:31:23 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#2715
No description provided.
Delete Branch "dpschen/frontend:feature/improve-task-loading-logic"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?