vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: use fetch instead of axios for deploy preview #2719

Merged
konrad merged 1 commits from dpschen/frontend:feature/use-fetch-instead-of-axios into main 2022-11-22 13:11:28 +00:00
Conversation 11 Commits 1 Files Changed 2 +24 -15
dpschen commented 2022-11-17 10:57:33 +00:00
Member
Copy Link

Since we use > node 18 nothing speaks against removing the axios dependency for the scripts

Since we use > node 18 nothing speaks against removing the axios dependency for the scripts
dpschen added the
dependencies
area/internal-code
 labels 2022-11-17 10:57:33 +00:00
dpschen requested review from konrad 2022-11-17 16:36:47 +00:00
konrad was assigned by dpschen 2022-11-17 16:36:50 +00:00
dpschen changed title from WIP: feat: use fetch instead of axios for deploy preview to feat: use fetch instead of axios for deploy preview 2022-11-17 16:36:52 +00:00
konrad commented 2022-11-17 16:38:46 +00:00
Owner
Copy Link

CI fails :/

CI fails :/
dpschen commented 2022-11-17 16:40:10 +00:00
Author
Member
Copy Link

Yes, because I changed that file:

+ shasum -a 384 -c ./scripts/deploy-preview-netlify.js.sha384
shasum: WARNING: 1 computed checksum did NOT match
./scripts/deploy-preview-netlify.js: FAILED
Yes, because I changed that file: ``` + shasum -a 384 -c ./scripts/deploy-preview-netlify.js.sha384 shasum: WARNING: 1 computed checksum did NOT match ./scripts/deploy-preview-netlify.js: FAILED ```
konrad commented 2022-11-17 16:41:53 +00:00
Owner
Copy Link

Can you regenerate the checksum?

Can you regenerate the checksum?
👍 1
dpschen force-pushed feature/use-fetch-instead-of-axios from 1b8c140dfd to 9547a32ece 2022-11-18 13:09:09 +00:00 Compare
konrad commented 2022-11-18 13:47:15 +00:00
Owner
Copy Link

Not sure why the bot did not post the comment here.

Not sure why the bot did not post the comment here.
dpschen commented 2022-11-18 14:04:19 +00:00
Author
Member
Copy Link

Not sure why the bot did not post the comment here.

I guess because it was initially not working.

OR because I broke something with the bot in that script?

> Not sure why the bot did not post the comment here. I guess because it was initially not working. _OR_ because I broke something with the bot in that script?
konrad commented 2022-11-18 14:05:14 +00:00
Owner
Copy Link

Not sure, the bot said

Preview comment sent successfully to PR #2719!

in the CI logs https://drone.kolaente.de/vikunja/frontend/11389/1/9

Not sure, the bot said > Preview comment sent successfully to PR #2719! in the CI logs https://drone.kolaente.de/vikunja/frontend/11389/1/9
dpschen commented 2022-11-18 14:09:59 +00:00
Author
Member
Copy Link

Not sure, the bot said

Preview comment sent successfully to PR #2719!

in the CI logs https://drone.kolaente.de/vikunja/frontend/11389/1/9

Just saw that. Mhh but I only await the response. I guess I should check response.ok as well. Will add that.

> Not sure, the bot said > > > Preview comment sent successfully to PR #2719! > > in the CI logs https://drone.kolaente.de/vikunja/frontend/11389/1/9 Just saw that. Mhh but I only await the response. I guess I should check `response.ok` as well. Will add that.
👍 1
dpschen force-pushed feature/use-fetch-instead-of-axios from 9547a32ece to 76c5531287 2022-11-18 14:18:24 +00:00 Compare
konrad commented 2022-11-18 14:28:11 +00:00
Owner
Copy Link

Now there's

Could not send preview comment to PR #2719! HTTP error, status = 422

Now there's > Could not send preview comment to PR #2719! HTTP error, status = 422
dpschen commented 2022-11-19 19:36:51 +00:00
Author
Member
Copy Link

Any idea how I can debug this locally?

Any idea how I can debug this locally?
dpschen force-pushed feature/use-fetch-instead-of-axios from 76c5531287 to a8836f2ea4 2022-11-21 17:31:04 +00:00 Compare
dpschen force-pushed feature/use-fetch-instead-of-axios from a8836f2ea4 to 09ac6716ee 2022-11-21 17:42:51 +00:00 Compare
frederick commented 2022-11-21 17:46:42 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2719-feature-use-fetch-instead-of-axi--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2719-feature-use-fetch-instead-of-axi--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
🎉 1 🚀 1 ✅ 1
dpschen commented 2022-11-21 17:49:35 +00:00
Author
Member
Copy Link

Works now.
I had two mistakes:

  • I didn't get that the object with the body inside was already part of the message. I don't use axios often enough and thought that just the string is the message.
  • I didn't JSON.stringify the object.
Works now. I had two mistakes: - I didn't get that the object with the body inside was already part of the message. I don't use axios often enough and thought that just the string is the message. - I didn't `JSON.stringify` the object.
konrad merged commit 93d95b0821 into main 2022-11-22 13:11:28 +00:00
konrad deleted branch feature/use-fetch-instead-of-axios 2022-11-22 13:11:28 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#2719
No description provided.
Delete Branch "dpschen/frontend:feature/use-fetch-instead-of-axios"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?