vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: more horizontal space on mobile #2722

Merged
konrad merged 1 commits from dpschen/frontend:feature/more-horizontal-space-on-mobile into main 2022-11-17 16:17:20 +00:00
Conversation 1 Commits 1 Files Changed 3 +16 -20
dpschen commented 2022-11-17 14:36:06 +00:00
Member
Copy Link

By adding less outer padding we keep more screen space. This is important especially for small screens.
I assumed that in the task view the background of the list is not that important

By adding less outer padding we keep more screen space. This is important especially for small screens. I assumed that in the task view the background of the list is not _that_ important
dpschen added the
kind/feature
changes requested
 labels 2022-11-17 14:36:06 +00:00
konrad was assigned by dpschen 2022-11-17 14:36:06 +00:00
frederick commented 2022-11-17 14:42:01 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2722-feature-more-horizontal-space-on--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2722-feature-more-horizontal-space-on--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
konrad reviewed 2022-11-17 15:38:26 +00:00
src/components/home/contentAuth.vue Outdated
@ -169,3 +165,2 @@
margin-left: 0;
padding-top: 1.5rem;
min-height: calc(100vh - 4rem);
min-height: calc(100dvh - 4rem);
konrad commented 2022-11-17 15:38:26 +00:00
Owner

dvh are a nice solution here but the browser support is really poor. We should at least add a fallback, maybe even not using them.

`dvh` are a nice solution here but the browser support is really poor. We should at least add a fallback, maybe even not using them.
dpschen commented 2022-11-17 16:01:31 +00:00
Author
Member

We should, because support should soon be better. And this makes really sense for iPhone. But you're right! I thought that postcss-preset-env adds vh as fallback automatically, but probably they decided against it because dvh is not 100% the same as vh, but instead, what you would actually expect vh to be. :D

We should, because support should soon be better. And this makes _really_ sense for iPhone. But you're right! I thought that postcss-preset-env adds `vh` as fallback automatically, but probably they decided against it because `dvh` is not 100% the same as `vh`, but instead, what you would actually expect `vh` to be. :D
dpschen commented 2022-11-17 16:09:09 +00:00
Author
Member

After further thinking I removed dvh now. Not because it's wrong, but because it's not used anywhere else. And since some height calculations depend on each other it might break something else if I use it only here.

I might add dvh as mobile optimization at some point. But then everywhere where it's needed at the same time.

After further thinking I removed `dvh` now. Not because it's wrong, but because it's not used anywhere else. And since some height calculations depend on each other it might break something else if I use it _only_ here. I might add `dvh` as mobile optimization at some point. But then everywhere where it's needed at the same time.
👍 1
konrad marked this conversation as resolved
dpschen force-pushed feature/more-horizontal-space-on-mobile from ebcc0db1e7 to 4c03adb6e2 2022-11-17 16:07:41 +00:00 Compare
konrad approved these changes 2022-11-17 16:14:12 +00:00
konrad scheduled this pull request to auto merge when all checks succeed 2022-11-17 16:14:24 +00:00
konrad merged commit b42e4cca59 into main 2022-11-17 16:17:20 +00:00
dpschen deleted branch feature/more-horizontal-space-on-mobile 2022-11-17 16:34:22 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#2722
No description provided.
Delete Branch "dpschen/frontend:feature/more-horizontal-space-on-mobile"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?