feat: add @intlify/unplugin-vue-i18n #2772

Merged
konrad merged 1 commits from dpschen/frontend:feature/add-unplugin-vue-i18n into main 2022-12-02 15:16:16 +00:00
Member
  • only use needed modules
  • optimise language loading order
  • disable i18n legacy mode

This replaces #2676
When you don't use the

- only use needed modules - optimise language loading order - disable i18n legacy mode This replaces https://kolaente.dev/vikunja/frontend/pulls/2676 When you don't use the
dpschen added the
changes requested
area/internal-code
labels 2022-12-02 11:32:45 +00:00
konrad was assigned by dpschen 2022-12-02 11:32:45 +00:00
dpschen force-pushed feature/add-unplugin-vue-i18n from eeac378749 to 2d65447fcb 2022-12-02 11:35:52 +00:00 Compare
dpschen changed title from WIP: feat: add @intlify/unplugin-vue-i18n to feat: add @intlify/unplugin-vue-i18n 2022-12-02 11:36:00 +00:00
Member

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2772-feature-add-unplugin-vue-i18n--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2772-feature-add-unplugin-vue-i18n--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
konrad reviewed 2022-12-02 14:36:19 +00:00
@ -108,2 +108,3 @@
app.mount('#app')
setLanguage().then(() => {
app.mount('#app')

So the current locale will be loaded before the app is even mounted?

So the current locale will be loaded before the app is even mounted?
Author
Member

Yes. This might impct the loading speed a bit. But might improve the perceived speed at the same time. Also the user get's to see the language for the loading that he probably used the last time. I just realize that we should add a language selector on the login, reset etc screens.

Yes. This might impct the loading speed a bit. But might improve the perceived speed at the same time. Also the user get's to see the language for the loading that he probably used the last time. I just realize that we should add a language selector on the login, reset etc screens.
Author
Member

My original goal was to also remove the default language until I realized that it's also used as a fallback. Because of that no matter what english has to be loaded, which is annoying. Would be better if we could be sure that all strings are in all languages so that even if we need to fallback, that fallback will already be part of the incompletely translated local language file.

My original goal was to also remove the default language until I realized that it's also used as a fallback. Because of that no matter what english has to be loaded, which is annoying. Would be better if we could be sure that all strings are in all languages so that even if we need to fallback, that fallback will already be part of the incompletely translated local language file.

Would be better if we could be sure that all strings are in all languages so that even if we need to fallback, that fallback will already be part of the incompletely translated local language file.

Doesn't crowdin already does this? https://kolaente.dev/vikunja/frontend/src/branch/main/src/i18n/lang/nl-NL.json#L21

> Would be better if we could be sure that all strings are in all languages so that even if we need to fallback, that fallback will already be part of the incompletely translated local language file. Doesn't crowdin already does this? https://kolaente.dev/vikunja/frontend/src/branch/main/src/i18n/lang/nl-NL.json#L21
konrad approved these changes 2022-12-02 15:16:06 +00:00
konrad left a comment
Owner

Seems to work great!

Seems to work great!
konrad merged commit b44d11cfc0 into main 2022-12-02 15:16:16 +00:00
konrad deleted branch feature/add-unplugin-vue-i18n 2022-12-02 15:16:16 +00:00
This repo is archived. You cannot comment on pull requests.
No description provided.