vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat(netlify): abstract createSlug helper function #2923

Merged
konrad merged 2 commits from dpschen/frontend:feature/abstract-createSlug-helper into main 2023-01-05 16:46:45 +00:00
Conversation 2 Commits 2 Files Changed 2 +11 -7
dpschen commented 2023-01-05 13:06:27 +00:00
Member
Copy Link

Fun fact:
There is a slugify library included in the netlify dependencies.

Fun fact: There is [a slugify library included in the netlify dependencies](https://kolaente.dev/vikunja/frontend/src/commit/b71d41c5ec7e0cc42eae51f917f853b95b4c952c/pnpm-lock.yaml#L2175).
dpschen added the
area/internal-code
 label 2023-01-05 13:06:27 +00:00
konrad was assigned by dpschen 2023-01-05 13:06:27 +00:00
dpschen added 1 commit 2023-01-05 13:06:28 +00:00
continuous-integration/drone/pr Build is failing Details
9ebc6846d7
feat(netlify): abstract createSlug helper function
konrad approved these changes 2023-01-05 13:31:47 +00:00
konrad left a comment
Owner

Not sure why the CI failed, looks good

Not sure why the CI failed, looks good
konrad scheduled this pull request to auto merge when all checks succeed 2023-01-05 13:31:59 +00:00
dpschen commented 2023-01-05 16:30:21 +00:00
Author
Member
Copy Link

Checksum needs to be updated again I think

Checksum needs to be updated again I think
konrad added 1 commit 2023-01-05 16:38:43 +00:00
continuous-integration/drone/pr Build is passing Details
7e27eecced
fix(ci): sign drone config
frederick commented 2023-01-05 16:41:45 +00:00
Member
Copy Link

Hi dpschen!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://2923-feature-abstract-createslug-help--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi dpschen! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://2923-feature-abstract-createslug-help--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.
konrad merged commit 6a03972f16 into main 2023-01-05 16:46:45 +00:00
This repo is archived. You cannot comment on pull requests.
Reviewers
No reviewers
konrad
Labels
Clear labels   
area/internal-code

   
changes requested

   
confirmed

   
dependencies

   
duplicate

This issue or pull request already exists

  
good first issue

   
help wanted

Need some help

  
hosting

   
invalid

Something is wrong

  
kind/bug

Something is not working

  
kind/feature

New feature

  
question

More information is needed

  
wontfix

This won't be fixed

No Label
area/internal-code
changes requested
confirmed
dependencies
duplicate
good first issue
help wanted
hosting
invalid
kind/bug
kind/feature
question
wontfix
Milestone
Clear milestone
No items
No Milestone
Projects
Clear projects
No project
Assignees
Clear assignees
No Assignees
konrad
3 Participants
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: vikunja/frontend#2923
No description provided.
Delete Branch "dpschen/frontend:feature/abstract-createSlug-helper"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?