feat: assign teams via oidc #3033

viehlieb · 2023-01-30T15:31:27Z

viehlieb commented

2023-01-30 15:31:27 +00:00

Assigning teams via oidc

Allow team assignment via oidc.
PR comes together with pull request from

vikunja/api#1393

Things changed:

Extend provider to include "scope"
extend team to include "oidcId" as String
disallow editing of oidc teams
mark teams from sso

## Assigning teams via oidc Allow team assignment via oidc. PR comes together with pull request from https://kolaente.dev/vikunja/api/pulls/1393 Things changed: * Extend provider to include "scope" * extend team to include "oidcId" as String * disallow editing of oidc teams * mark teams from sso

viehlieb added 4 commits 2023-01-30 15:31:27 +00:00

4ee785a3df allow custom_scope to be demanded by vikunja, add scope to IProvider

b28444148e extend teams model to include oidcId

44719c9780 mark teams from sso in ListTeams

continuous-integration/drone/pr Build is passing Details

85f1262fc4 make sso teams non editable by neither admin nor team members (except for leaving team)

konrad requested changes 2023-01-31 14:52:31 +00:00

src/modelTypes/ITeam.ts Outdated

						
				@ -9,6 +9,7 @@ export interface ITeam extends IAbstract {

					description: string

					members: ITeamMember[]

					right: Right

					oidcId: string

konrad commented

2023-01-31 14:51:55 +00:00

What's the null value of this? An empty string?

src/views/teams/EditTeam.vue Outdated

						
				@ -4,3 +4,3 @@

						:class="{ 'is-loading': teamService.loading }"

					>

						<card class="is-fullwidth" v-if="userIsAdmin" :title="title">

						<card class="is-fullwidth" v-if="userIsAdmin && team.oidcId == 0" :title="title">

konrad commented

2023-01-31 14:52:27 +00:00

If oidcId is a string, the comparison here does not make sense.

If `oidcId` is a string, the comparison here does not make sense.

src/views/teams/ListTeams.vue Outdated

						
				@ -16,0 +16,4 @@

										{{ t.name }}{{ " (sso: " + t.oidcId + ")" }}

									</p>

									<p v-else>

										{{ t.name }}

konrad commented

2023-01-31 14:51:29 +00:00

Please use something like this instead:

{{ t.name + (t.oidcId !== 0 ? ` (sso: ${t.oidcId})` : '') }}

Please use something like this instead: ``` {{ t.name + (t.oidcId !== 0 ? ` (sso: ${t.oidcId})` : '') }} ```

frederick commented

2023-01-31 14:57:38 +00:00

Hi viehlieb!

Thank you for creating a PR!

I've deployed the changes of this PR on a preview environment under this URL: https://3033-assignteamsviaoidc--vikunja-frontend-preview.netlify.app

You can use this url to view the changes live and test them out.
You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/.

Have a nice day!

Beep boop, I'm a bot.

Hi viehlieb! Thank you for creating a PR! I've deployed the changes of this PR on a preview environment under this URL: https://3033-assignteamsviaoidc--vikunja-frontend-preview.netlify.app You can use this url to view the changes live and test them out. You will need to manually connect this to an api running somehwere. The easiest to use is https://try.vikunja.io/. Have a nice day! > Beep boop, I'm a bot.

dpschen commented

2023-02-10 13:35:01 +00:00

@viehlieb: could you take a look at this? Thanks :)

viehlieb added 1 commit 2023-02-10 14:55:13 +00:00