From 67f3277ae2b5e616d1be5ce285dd1abb7071693a Mon Sep 17 00:00:00 2001 From: WofWca Date: Tue, 28 Feb 2023 13:35:53 +0400 Subject: [PATCH 1/3] perf: import some modules dynamically --- src/App.vue | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/src/App.vue b/src/App.vue index 95087120a..eae16a428 100644 --- a/src/App.vue +++ b/src/App.vue @@ -37,8 +37,6 @@ import NoAuthWrapper from '@/components/misc/no-auth-wrapper.vue' import Ready from '@/components/misc/ready.vue' import {setLanguage} from '@/i18n' -import AccountDeleteService from '@/services/accountDelete' -import {success} from '@/message' import {useAuthStore} from '@/stores/auth' import {useBaseStore} from '@/stores/base' @@ -68,8 +66,11 @@ watch(accountDeletionConfirm, async (accountDeletionConfirm) => { return } + const messageP = import('@/message') + const AccountDeleteService = (await import('@/services/accountDelete')).default const accountDeletionService = new AccountDeleteService() await accountDeletionService.confirm(accountDeletionConfirm) + const {success} = await messageP success({message: t('user.deletion.confirmSuccess')}) authStore.refreshUserInfo() }, { immediate: true }) -- 2.45.1 From eda1df19dc9b931ca37c37e8bae075061bf2147f Mon Sep 17 00:00:00 2001 From: WofWca Date: Tue, 28 Feb 2023 14:07:19 +0400 Subject: [PATCH 2/3] refactor: put dynamic imports at the top of the file --- src/App.vue | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/src/App.vue b/src/App.vue index eae16a428..5b00c047a 100644 --- a/src/App.vue +++ b/src/App.vue @@ -46,6 +46,9 @@ import {useBodyClass} from '@/composables/useBodyClass' import AddToHomeScreen from '@/components/home/AddToHomeScreen.vue' import DemoMode from '@/components/home/DemoMode.vue' +const importAccountDeleteService = async () => (await import('@/services/accountDelete')).default +const importSuccess = async () => (await import('@/message')).success + const baseStore = useBaseStore() const authStore = useAuthStore() const router = useRouter() @@ -66,11 +69,11 @@ watch(accountDeletionConfirm, async (accountDeletionConfirm) => { return } - const messageP = import('@/message') - const AccountDeleteService = (await import('@/services/accountDelete')).default + const successP = importSuccess() + const AccountDeleteService = await importAccountDeleteService() const accountDeletionService = new AccountDeleteService() await accountDeletionService.confirm(accountDeletionConfirm) - const {success} = await messageP + const success = await successP success({message: t('user.deletion.confirmSuccess')}) authStore.refreshUserInfo() }, { immediate: true }) -- 2.45.1 From 7a3555a48c885cacc7b708867afe2a3c1fce37c1 Mon Sep 17 00:00:00 2001 From: WofWca Date: Tue, 28 Feb 2023 19:13:07 +0400 Subject: [PATCH 3/3] refactor: swap logic around --- src/App.vue | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/src/App.vue b/src/App.vue index 5b00c047a..77d3dacf4 100644 --- a/src/App.vue +++ b/src/App.vue @@ -46,8 +46,8 @@ import {useBodyClass} from '@/composables/useBodyClass' import AddToHomeScreen from '@/components/home/AddToHomeScreen.vue' import DemoMode from '@/components/home/DemoMode.vue' -const importAccountDeleteService = async () => (await import('@/services/accountDelete')).default -const importSuccess = async () => (await import('@/message')).success +const importAccountDeleteService = () => import('@/services/accountDelete') +const importMessage = () => import('@/message') const baseStore = useBaseStore() const authStore = useAuthStore() @@ -69,11 +69,11 @@ watch(accountDeletionConfirm, async (accountDeletionConfirm) => { return } - const successP = importSuccess() - const AccountDeleteService = await importAccountDeleteService() + const messageP = importMessage() + const AccountDeleteService = (await importAccountDeleteService()).default const accountDeletionService = new AccountDeleteService() await accountDeletionService.confirm(accountDeletionConfirm) - const success = await successP + const {success} = await messageP success({message: t('user.deletion.confirmSuccess')}) authStore.refreshUserInfo() }, { immediate: true }) -- 2.45.1