vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: Edit relative reminders #3248

Merged
konrad merged 27 commits from ce72/frontend:main into main 2023-06-10 17:04:10 +00:00
Conversation 18 Commits 27 Files Changed 18 +5
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 85ffed4d9a - Show all commits

5
src/models/task.ts
View File

@ -70,6 +70,11 @@ export default class TaskModel extends AbstractModel<ITask> implements ITask {
repeatAfter: number | IRepeatAfter = 0
repeatFromCurrentDate = false
repeatMode: IRepeatMode = TASK_REPEAT_MODES.REPEAT_MODE_DEFAULT
/* Make sure to not return reminderDates to the server.
The server currently supports both reminderDates (old API) and reminder (new API) and assumes the old logic
if it still receives reminderDates.
This line and reminderDates attributes will be removed after https://kolaente.dev/vikunja/api/pulls/1448 was merged.
*/
reminderDates = null
ce72 marked this conversation as resolved Outdated
dpschen commented 2023-03-20 16:49:46 +00:00
Outdated
Review
Copy Link

If reminderDates is null why do we still define it?

If `reminderDates` is `null` why do we still define it?
ce72 commented 2023-03-20 20:33:47 +00:00
Outdated
Review
Copy Link

We want to make sure to not return reminderDates to the server. The api currently supports both reminderDates (old API) and reminder (new API). If the frontend still sends the old reminderDates array back to the server, it assumes the old logic and ignores the new reminders. The whole thing will be removed, if the reminderDates will be entirely removed from the server.

We want to make sure to not return reminderDates to the server. The api currently supports both reminderDates (old API) and reminder (new API). If the frontend still sends the old reminderDates array back to the server, it assumes the old logic and ignores the new reminders. The whole thing will be removed, if the reminderDates will be entirely removed from the server.
👍 1
dpschen commented 2023-03-27 21:45:01 +00:00
Outdated
Review
Copy Link

Can you add this as comment to this line?

Can you add this as comment to this line?
ce72 commented 2023-03-28 05:53:37 +00:00
Outdated
Review
Copy Link

ok

ok
reminders: ITaskReminder[] = []
parentTaskId: ITask['id'] = 0