vikunja/frontend
Archived
6
39
Fork 48
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: Edit relative reminders #3248

Merged
konrad merged 27 commits from ce72/frontend:main into main 2023-06-10 17:04:10 +00:00
Conversation 18 Commits 27 Files Changed 18 +2 -1
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit eac19e28d6 - Show all commits

3
src/components/tasks/partials/reminder-period.vue
View File

@ -98,7 +98,7 @@ watch(
const p = secondsToPeriod(value?.relativePeriod) const p = secondsToPeriod(value?.relativePeriod)
konrad commented 2023-03-28 10:01:23 +00:00
Outdated
Review
Copy Link

What does sign mean in this context?

What's the advantage of using an object here instead of individual refs?

What does `sign` mean in this context? What's the advantage of using an object here instead of individual `ref`s?
period.value.durationUnit = p.unit period.value.durationUnit = p.unit
period.value.duration = p.amount period.value.duration = p.amount
period.value.relativeTo = value?.relativeTo period.value.relativeTo = value?.relativeTo || REMINDER_PERIOD_RELATIVE_TO_TYPES.DUEDATE
}, },
{immediate: true}, {immediate: true},
) )
@ -117,6 +117,7 @@ function updateData() {
display: flex; display: flex;
flex-direction: column; flex-direction: column;
gap: .25rem; gap: .25rem;
padding: .5rem .5rem 0;
.input, .select select { .input, .select select {
width: 100% !important; width: 100% !important;