vikunja/frontend
Archived
6
39
Fork 48
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feature/projects-all-the-way-down #3323

Merged
konrad merged 123 commits from feature/projects-all-the-way-down into main 2023-05-30 10:09:40 +00:00
Conversation 16 Commits 123 Files Changed 85 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 0dd6f82a0e - Show all commits

4
src/components/home/navigation.vue
View File

@ -4,7 +4,7 @@
<router-link :to="{name: 'home'}" class="logo">
<Logo width="164" height="48"/>
</router-link>
<ul class="menu-list other-menu-items">
<menu class="menu-list other-menu-items">
dpschen marked this conversation as resolved Outdated
dpschen commented 2023-04-01 12:59:35 +00:00
Outdated
Review
Copy Link

Something that I don't know that long myself: adding a <ul> inside a <nav> doesn't give added benefit if we hide the list-item, because there are no added semantics. So listing the links is ok.

Something that I don't know that long myself: adding a `<ul>` inside a `<nav>` doesn't give added benefit if we hide the `list-item`, because there are no added semantics. So listing the links is ok.
✅ 1
konrad commented 2023-04-01 14:57:09 +00:00
Outdated
Review
Copy Link

So we could get rid of the ul entierly and only add the links?

So we could get rid of the `ul` entierly and only add the links?
dpschen commented 2023-04-01 15:44:10 +00:00
Outdated
Review
Copy Link

That was my idea. But wait with doing this. Because when I wrote this I forgot that menu-list adds style the is structure dependant (might even be that the original class is coming from bulma).

That was my idea. But wait with doing this. Because when I wrote this I forgot that menu-list adds style the is structure dependant (might even be that the original class is coming from bulma).
👍 1
dpschen commented 2023-04-01 16:16:46 +00:00
Outdated
Review
Copy Link

If Bulma doesn't require you to use <ul> use <menu> instead.

If Bulma doesn't require you to use `<ul>` use `<menu>` instead.
👍 1
dpschen commented 2023-04-03 10:08:55 +00:00
Outdated
Review
Copy Link

menu still missing here. (you changed it in ProjectsNavigation).

`menu` still missing here. (you changed it in ProjectsNavigation).
konrad commented 2023-04-03 10:10:13 +00:00
Outdated
Review
Copy Link

Done

Done
<li>
<router-link :to="{ name: 'home'}" v-shortcut="'g o'">
<span class="menu-item-icon icon">
@ -45,7 +45,7 @@
{{ $t('team.title') }}
</router-link>
</li>
</ul>
</menu>
</nav>
<Loading variant="small" v-if="projectsLoading"/>
dpschen marked this conversation as resolved Outdated
dpschen commented 2023-04-03 10:06:39 +00:00
Outdated
Review
Copy Link

Move v-if to front

Move `v-if` to front
✅ 1
konrad commented 2023-04-10 18:59:51 +00:00
Outdated
Review
Copy Link

Done

Done