vikunja/frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feature/projects-all-the-way-down #3323

Merged
konrad merged 123 commits from feature/projects-all-the-way-down into main 2023-05-30 10:09:40 +00:00
Conversation 16 Commits 123 Files Changed 85 +1 -1
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 1344026494 - Show all commits

2
src/components/home/ProjectsNavigationItem.vue
View File

@ -11,12 +11,12 @@
>
<icon icon="chevron-down" :class="{ 'project-is-collapsed': !childProjectsOpen }"/>
</BaseButton>
<span class="collapse-project-button-placeholder" v-else></span>
<BaseButton
:to="{ name: 'project.index', params: { projectId: project.id} }"
class="list-menu-link"
:class="{'router-link-exact-active': currentProject.id === project.id}"
>
<span class="collapse-project-button-placeholder" v-if="!canCollapse || childProjects?.length === 0"></span>
<ColorBubble
v-if="project.hexColor !== ''"
dpschen commented 2023-04-02 23:00:55 +00:00
Outdated
Review
Copy Link

Fix indention

Fix indention
dpschen commented 2023-04-02 23:02:08 +00:00
Outdated
Review
Copy Link

Pass 'handle class name from parent => separate concerns / source of truth

Pass 'handle class name from parent => separate concerns / source of truth
konrad commented 2023-04-10 18:50:36 +00:00
Outdated
Review
Copy Link

But the indention is correct?

But the indention is correct?
👍 1
konrad commented 2023-04-10 18:51:25 +00:00
Outdated
Review
Copy Link

Pass 'handle class name from parent => separate concerns / source of truth

Can you explain that a little more?

> Pass 'handle class name from parent => separate concerns / source of truth Can you explain that a little more?
dpschen commented 2023-04-11 14:31:35 +00:00
Outdated
Review
Copy Link

The handle selector is used in the child. Currently we define it in the parent. We should pass this information down to the child. Might also be via creating a slot in the child where we put in the handle.

The `handle` selector is used in the child. Currently we define it in the parent. We should pass this information down to the child. Might also be via creating a slot in the child where we put in the handle.
:color="project.hexColor"