vikunja/frontend
Archived
6
39
Fork 48
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feature/projects-all-the-way-down #3323

Merged
konrad merged 123 commits from feature/projects-all-the-way-down into main 2023-05-30 10:09:40 +00:00
Conversation 16 Commits 123 Files Changed 85 +6 -11
1 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 26bec05174 - Show all commits

17
src/views/tasks/TaskDetailView.vue
View File

@ -450,7 +450,7 @@
</template>
<script lang="ts" setup>
import {ref, reactive, toRef, shallowReactive, computed, watch, nextTick, type PropType} from 'vue'
import {ref, reactive, toRef, shallowReactive, computed, watch, watchEffect, nextTick, type PropType} from 'vue'
import {useRouter, type RouteLocation} from 'vue-router'
import {useI18n} from 'vue-i18n'
import {unrefElement} from '@vueuse/core'
@ -539,16 +539,11 @@ const visible = ref(false)
konrad marked this conversation as resolved Outdated
dpschen commented 2023-04-11 16:32:49 +00:00
Outdated
Review
Copy Link

getProjectById returns undefined if there is no project with that id. So why not use that directly?

`getProjectById` returns `undefined` if there is no project with that id. So why not use that directly?
konrad commented 2023-04-12 10:31:31 +00:00
Outdated
Review
Copy Link

Done

Done
const taskId = toRef(props, 'taskId')
const project = computed(() => {
if (!task.projectId) {
return {
project: null,
}
}
const project = projectStore.getProjectById(task.projectId)
baseStore.handleSetCurrentProject({project})
return project
const project = computed(() => task.projectId ? projectStore.getProjectById(task.projectId) : null)
watchEffect(() => {
baseStore.handleSetCurrentProject({
project: project.value,
})
})
konrad marked this conversation as resolved Outdated
dpschen commented 2023-03-28 17:14:31 +00:00
Outdated
Review
Copy Link

Very bad pattern.

A side effect of a computed can lead to various weird issues. Instead there should be a watcher! Why not use getProjectById directly?

const project = computed(() => projectStore.getProjectById(task.projectId)})

watchEffect(() => {
	baseStore.handleSetCurrentProject({
    	project: project.value
   	})
})
__Very__ bad pattern. A side effect of a computed can lead to various weird issues. Instead there should be a watcher! Why not use `getProjectById` directly? ```ts const project = computed(() => projectStore.getProjectById(task.projectId)}) watchEffect(() => { baseStore.handleSetCurrentProject({ project: project.value }) }) ```
konrad commented 2023-03-28 19:32:12 +00:00
Outdated
Review
Copy Link

I don't even know why I moved that into the computed instead of leaving the watcher as it was before. Changed it back now.

I don't even know why I moved that into the computed instead of leaving the watcher as it was before. Changed it back now.
const canWrite = computed(() => (