vikunja/frontend
Archived
6
39
Fork 48
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feature/projects-all-the-way-down #3323

Merged
konrad merged 123 commits from feature/projects-all-the-way-down into main 2023-05-30 10:09:40 +00:00
Conversation 16 Commits 123 Files Changed 85 +6 -6
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 2bb7ff1803 - Show all commits

8
src/components/home/ProjectsNavigation.vue
View File

@ -8,13 +8,13 @@
handle=".handle"
tag="ul"
dpschen marked this conversation as resolved Outdated
dpschen commented 2023-04-01 16:08:00 +00:00
Outdated
Review
Copy Link

Use <menu> (now I remembered the correct element).

Use [`<menu>`](https://developer.mozilla.org/en-US/docs/Web/HTML/Element/menu) (now I remembered the correct element).
✅ 1
konrad commented 2023-04-01 20:02:14 +00:00
Outdated
Review
Copy Link

Done

Done
item-key="id"
:disabled="!allowDrag"
:disabled="!canEditOrder"
:component-data="{
type: 'transition-group',
name: !drag ? 'flip-list' : null,
class: [
'menu-list can-be-hidden',
{ 'dragging-disabled': !allowDrag }
{ 'dragging-disabled': !canEditOrder }
]
}"
>
@ -68,7 +68,7 @@
<ProjectsNavigation
dpschen marked this conversation as resolved Outdated
dpschen commented 2023-03-28 13:10:01 +00:00
Outdated
Review
Copy Link

Nice!

Nice!
🎉 1
v-if="!collapsedProjects[p.id]"
dpschen commented 2023-04-01 13:02:26 +00:00
Outdated
Review
Copy Link

Also don't render if there are no child projects.

Also don't render if there are no child projects.
konrad commented 2023-04-01 14:52:01 +00:00
Outdated
Review
Copy Link

But then it won't be possible to drag a project "under" a parent to make it a child of that parent.

But then it won't be possible to drag a project "under" a parent to make it a child of that parent.
v-model="p.childProjects"
:allow-drag="true"
:can-edit-order="true"
/>
</li>
</template>
@ -94,7 +94,7 @@ import {useProjectStore} from '@/stores/projects'
const props = defineProps<{
modelValue: IProject[],
allowDrag: boolean,
canEditOrder: boolean,
dpschen marked this conversation as resolved Outdated
dpschen commented 2023-03-28 13:12:52 +00:00
Outdated
Review
Copy Link

Should have a default value.

When is allowDrag === true? In case this is related to edit rights we should align the variable names.

Should have a default value. When is `allowDrag === true`? In case this is related to edit rights we should align the variable names.
✅ 1
dpschen commented 2023-03-28 13:15:02 +00:00
Outdated
Review
Copy Link

Just saw when it's true. Can we rename to the concrete action? Because the order might also be changed by something else than dragging in the future. How about canEditOrder?

Just saw when it's true. Can we rename to the concrete action? Because the order might also be changed by something else than dragging in the future. How about `canEditOrder`?
konrad commented 2023-03-28 13:33:54 +00:00
Outdated
Review
Copy Link

Can we rename to the concrete action? Because the order might also be changed by something else than dragging in the future. How about canEditOrder?

I think that's a good idea. Renamed it.

> Can we rename to the concrete action? Because the order might also be changed by something else than dragging in the future. How about canEditOrder? I think that's a good idea. Renamed it.
👍 1
}>()
dpschen commented 2023-04-11 15:06:45 +00:00
Outdated
Review
Copy Link

Danger! This should be handled in the store!
Inline editing of parent project!

Probably it would be best to create a new store method. Something like setOrder or changeOrder.

Danger! This should be handled in the store! Inline editing of parent project! Probably it would be best to create a new store method. Something like `setOrder` or `changeOrder`.
konrad commented 2023-04-12 08:46:21 +00:00
Outdated
Review
Copy Link

I was able to move the whole thing into the updateProject method of the store.

I was able to move the whole thing into the `updateProject` method of the store.
const emit = defineEmits(['update:modelValue'])

4
src/components/home/navigation.vue
View File

@ -49,11 +49,11 @@
</nav>
<nav class="menu" v-if="favoriteProjects">
dpschen marked this conversation as resolved Outdated
dpschen commented 2023-04-03 10:06:39 +00:00
Outdated
Review
Copy Link

Move v-if to front

Move `v-if` to front
✅ 1
konrad commented 2023-04-10 18:59:51 +00:00
Outdated
Review
Copy Link

Done

Done
<ProjectsNavigation v-model="favoriteProjects" :allow-drag="false"/>
<ProjectsNavigation v-model="favoriteProjects" :can-edit-order="false"/>
</nav>
<nav class="menu">
<ProjectsNavigation v-model="projects" :allow-drag="true"/>
<ProjectsNavigation v-model="projects" :can-edit-order="true"/>
</nav>
<PoweredByLink/>