feature/projects-all-the-way-down #3323
|
@ -26,9 +26,6 @@ const projects = computed({
|
|||
})
|
||||
konrad marked this conversation as resolved
Outdated
|
||||
const favoriteProjects = computed(() => projectStore.projectsArray
|
||||
.filter(p => !p.isArchived && p.isFavorite)
|
||||
konrad marked this conversation as resolved
Outdated
dpschen
commented
`favoriteProjects` also seems like something a store should export.
konrad
commented
Done Done
dpschen
commented
The top menu shouldn't have a padding top that has the sole purpose of creating space to the silbling component above. Since I still only check the code and don't have this branch running locally I'm not sure if the padding extends the background or something like that instead. If not this
The top menu shouldn't have a padding top that has the sole purpose of creating space to the silbling component above. Since I still only check the code and don't have this branch running locally I'm not sure if the padding extends the background or something like that instead.
If not this `.menu` should use margin-top:
```scss
.menu + .menu {
margin-top: math.div($navbar-padding, 2);
}
```
konrad
commented
Done. Done.
|
||||
.map(p => ({
|
||||
...p,
|
||||
}))
|
||||
.sort((a, b) => a.position - b.position))
|
||||
</script>
|
||||
konrad marked this conversation as resolved
Outdated
dpschen
commented
Why the mapping / returning of a copy? Why the mapping / returning of a copy?
konrad
commented
That was a relic, I've removed it now. That was a relic, I've removed it now.
|
||||
|
||||
|
|
Reference in New Issue
Block a user
Probably because you use
v-model
instead ofmodelValue
for ProjectsNavigation. I guess that when the template gets rendered it wants to bind to something like@update:modelValue="(newVal) => projects.value = newVal"
I've now changed it to
:modelValue
and that seems to work.