vikunja/frontend
Archived
6
39
Fork 48
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feature/projects-all-the-way-down #3323

Merged
konrad merged 123 commits from feature/projects-all-the-way-down into main 2023-05-30 10:09:40 +00:00
Conversation 16 Commits 123 Files Changed 85 +4 -5
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 46e825820c - Show all commits

6
src/components/home/navigation.vue
View File

@ -85,10 +85,8 @@ import ProjectsNavigation from '@/components/home/ProjectsNavigation.vue'
const baseStore = useBaseStore()
dpschen marked this conversation as resolved Outdated
dpschen commented 2023-03-28 13:19:22 +00:00
Outdated
Review
Copy Link

This computed as well.

This computed as well.
👍 1 ✅ 1
const projectStore = useProjectStore()
const projects = computed(() => projectStore.notArchivedRootProjects
.sort((a, b) => a.position - b.position))
const favoriteProjects = computed(() => projectStore.favoriteProjects
.sort((a, b) => a.position - b.position))
const projects = computed(() => projectStore.notArchivedRootProjects)
dpschen commented 2023-04-12 14:58:49 +00:00
Outdated
Review
Copy Link

This sorts the returned computed of the store
=> sort already in store OR create copy (worse performance)

Error in vue developer tools:

[Vue warn] Set operation on key "0" failed: target is readonly. [...]

This sorts the returned computed of the store => sort already in store OR create copy (worse performance) Error in vue developer tools: > [Vue warn] Set operation on key "0" failed: target is readonly. [...]
konrad commented 2023-04-14 15:21:55 +00:00
Outdated
Review
Copy Link

Now sorting in store, that seems to work (or at least there are no errors now)

Now sorting in store, that seems to work (or at least there are no errors now)
const favoriteProjects = computed(() => projectStore.favoriteProjects)
</script>
dpschen marked this conversation as resolved Outdated
dpschen commented 2023-03-28 13:25:20 +00:00
Outdated
Review
Copy Link

Simplify to

.sort((a, b) => a.position - b.position)
Simplify to ```ts .sort((a, b) => a.position - b.position) ```
✅ 1
konrad commented 2023-03-28 13:37:42 +00:00
Outdated
Review
Copy Link

Done.

Done.
dpschen commented 2023-04-12 14:59:00 +00:00
Outdated
Review
Copy Link

This sorts the returned computed of the store
=> sort already in store OR create copy (worse performance)

Error in vue developer tools:

[Vue warn] Set operation on key "0" failed: target is readonly. [...]

This sorts the returned computed of the store => sort already in store OR create copy (worse performance) Error in vue developer tools: > [Vue warn] Set operation on key "0" failed: target is readonly. [...]
konrad commented 2023-04-14 15:22:17 +00:00
Outdated
Review
Copy Link

Fixed as well.

Fixed as well.
<style lang="scss" scoped>

3
src/stores/projects.ts
View File

@ -32,7 +32,8 @@ export const useProjectStore = defineStore('project', () => {
// The projects are stored as an object which has the project ids as keys.
const projects = ref<ProjectState>({})
const projectsArray = computed(() => Object.values(projects.value))
const projectsArray = computed(() => Object.values(projects.value)
.sort((a, b) => a.position - b.position))
const notArchivedRootProjects = computed(() => projectsArray.value
dpschen commented 2023-04-11 15:28:24 +00:00
Outdated
Review
Copy Link

Since projects is of type object (defined by its type) this shouldn't work because !!{} === true.
Even if it would be undefined or null sometimes this should use Boolean(projects.value) for clarity instead.

Afaik there is no way around something like:

computed(() => Boolean(projectsArray.value.length))
Since `projects` is of type object (defined by its type) this shouldn't work because `!!{} === true`. Even if it would be undefined or null sometimes this should use `Boolean(projects.value)` for clarity instead. Afaik there is no way around something like: ```ts computed(() => Boolean(projectsArray.value.length)) ```
✅ 1
konrad commented 2023-04-12 09:31:25 +00:00
Outdated
Review
Copy Link

Fixed.

Fixed.
.filter(p => p.parentProjectId === 0 && !p.isArchived))
const favoriteProjects = computed(() => projectsArray.value
dpschen commented 2023-04-11 15:16:53 +00:00
Outdated
Review
Copy Link

This computed seems really unnecessary. Reason: We can achieve the same (and faster) by using: projects.value[id]. Since projects is exported we should replace uses of this computed. We might need to create new simple computeds where used. Depending on usecase something like

const myProject = computed(() => projects.value[myProjectId.value])
This computed seems really unnecessary. Reason: We can achieve the same (and faster) by using: `projects.value[id]`. Since `projects` is exported we should replace uses of this computed. We might need to create new simple computeds where used. Depending on usecase something like ```ts const myProject = computed(() => projects.value[myProjectId.value]) ```
konrad commented 2023-04-12 09:14:50 +00:00
Outdated
Review
Copy Link

We've actually been using computed for most uses of the store computed anyway. I've changed it to use the projects property of the store directly.

We've actually been using computed for most uses of the store computed anyway. I've changed it to use the `projects` property of the store directly.