vikunja/frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feature/projects-all-the-way-down #3323

Merged
konrad merged 123 commits from feature/projects-all-the-way-down into main 2023-05-30 10:09:40 +00:00
Conversation 16 Commits 123 Files Changed 85 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 4ab547810c - Show all commits

4
src/stores/projects.ts
View File

@ -111,12 +111,12 @@ export const useProjectStore = defineStore('project', () => {
const projectService = new ProjectService()
try {
await projectService.update(project)
const updatedProject = await projectService.update(project)
setProject(project)
// the returned project from projectService.update is the same!
konrad marked this conversation as resolved Outdated
dpschen commented 2023-04-11 15:34:08 +00:00
Outdated
Review
Copy Link

  • Use returned value from update function. Then klona shouldn't be necessary, right?

  • If I set an id for parentID in the passed project: will this update the parents childProjects?

- Use returned value from update function. Then klona shouldn't be necessary, right? - If I set an id for `parentID` in the passed project: will this update the parents childProjects?
konrad commented 2023-04-12 09:38:59 +00:00
Outdated
Review
Copy Link

Done.

Done.
// in order to not create a manipulation in pinia store we have to create a new copy
return klona(project)
return updatedProject
} catch (e) {
// Reset the project state to the initial one to avoid confusion for the user
setProject({