vikunja/frontend
Archived
6
39
Fork 48
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feature/projects-all-the-way-down #3323

Merged
konrad merged 123 commits from feature/projects-all-the-way-down into main 2023-05-30 10:09:40 +00:00
Conversation 16 Commits 123 Files Changed 85 +28 -28
1 changed files with 28 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 638d187a24 - Show all commits

56
src/components/home/ProjectsNavigation.vue
View File

@ -31,37 +31,37 @@
:class="{'is-loading': projectUpdating[p.id]}"
>
<section>
<BaseButton
:to="{ name: 'project.index', params: { projectId: p.id} }"
class="list-menu-link"
:class="{'router-link-exact-active': currentProject.id === p.id}"
>
<BaseButton
:to="{ name: 'project.index', params: { projectId: p.id} }"
class="list-menu-link"
:class="{'router-link-exact-active': currentProject.id === p.id}"
>
<span class="icon menu-item-icon handle">
<icon icon="grip-lines"/>
</span>
<ColorBubble
v-if="p.hexColor !== ''"
:color="p.hexColor"
class="mr-1"
/>
<span class="list-menu-title">{{ getProjectTitle(p) }}</span>
</BaseButton>
<BaseButton
v-if="p.id > 0"
class="favorite"
:class="{'is-favorite': p.isFavorite}"
@click="projectStore.toggleProjectFavorite(l)"
>
<icon :icon="p.isFavorite ? 'star' : ['far', 'star']"/>
</BaseButton>
<ProjectSettingsDropdown class="menu-list-dropdown" :project="p" v-if="p.id > 0">
<template #trigger="{toggleOpen}">
<BaseButton class="menu-list-dropdown-trigger" @click="toggleOpen">
<icon icon="ellipsis-h" class="icon"/>
</BaseButton>
</template>
</ProjectSettingsDropdown>
<span class="list-setting-spacer" v-else></span>
<ColorBubble
v-if="p.hexColor !== ''"
:color="p.hexColor"
class="mr-1"
/>
<span class="list-menu-title">{{ getProjectTitle(p) }}</span>
</BaseButton>
konrad marked this conversation as resolved Outdated
dpschen commented 2023-04-03 09:59:40 +00:00
Outdated
Review
Copy Link

Add types for emit

Add types for emit
konrad commented 2023-04-10 19:01:49 +00:00
Outdated
Review
Copy Link

Done

Done
<BaseButton
v-if="p.id > 0"
class="favorite"
konrad marked this conversation as resolved Outdated
dpschen commented 2023-04-03 10:03:14 +00:00
Outdated
Review
Copy Link

These options should either contain all dragOptions or be defined inline

These options should either contain all dragOptions or be defined inline
konrad commented 2023-04-10 19:01:34 +00:00
Outdated
Review
Copy Link

Moved it all inline.

Moved it all inline.
:class="{'is-favorite': p.isFavorite}"
@click="projectStore.toggleProjectFavorite(l)"
>
<icon :icon="p.isFavorite ? 'star' : ['far', 'star']"/>
</BaseButton>
<ProjectSettingsDropdown class="menu-list-dropdown" :project="p" v-if="p.id > 0">
<template #trigger="{toggleOpen}">
dpschen commented 2023-04-03 10:00:42 +00:00
Outdated
Review
Copy Link

Is this even necessary if we use modelValue instead of v-model for the draggable?

Is this even necessary if we use `modelValue` instead of `v-model` for the draggable?
konrad commented 2023-04-10 18:46:47 +00:00
Outdated
Review
Copy Link

v-model is required, using modelValue for the draggable component does not work.

`v-model` is required, using `modelValue` for the draggable component does not work.
<BaseButton class="menu-list-dropdown-trigger" @click="toggleOpen">
dpschen marked this conversation as resolved Outdated
dpschen commented 2023-04-01 13:08:47 +00:00
Outdated
Review
Copy Link

Didn't we just remove this condition, so that also one can also adjust settings of favorited lists?

Didn't we just remove this condition, so that also one can also adjust settings of favorited lists?
✅ 1
konrad commented 2023-04-01 14:56:21 +00:00
Outdated
Review
Copy Link

The condition is already in main: https://kolaente.dev/vikunja/frontend/src/branch/main/src/components/home/navigation.vue#L132

But editing favorites works just fine. This is about every project which actually exists, so no shared filters for example.

The condition is already in main: https://kolaente.dev/vikunja/frontend/src/branch/main/src/components/home/navigation.vue#L132 But editing favorites works just fine. This is about every project which actually exists, so no shared filters for example.
dpschen commented 2023-04-01 16:01:56 +00:00
Outdated
Review
Copy Link

My bad I confused favorite projects with the 'Favorite' project.

My bad I confused favorite projects with the 'Favorite' project.
👍 1
<icon icon="ellipsis-h" class="icon"/>
</BaseButton>
</template>
</ProjectSettingsDropdown>
<span class="list-setting-spacer" v-else></span>
</section>
<ProjectsNavigation
v-if="p.childProjects.length > 0"