vikunja/frontend
Archived
6
39
Fork 48
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feature/projects-all-the-way-down #3323

Merged
konrad merged 123 commits from feature/projects-all-the-way-down into main 2023-05-30 10:09:40 +00:00
Conversation 16 Commits 123 Files Changed 85 +19 -3
1 changed files with 19 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 63ba2982c9 - Show all commits

22
src/views/tasks/TaskDetailView.vue
View File

@ -14,9 +14,12 @@
ref="heading"
/>
<h6 class="subtitle" v-if="project?.id">
<router-link :to="{ name: 'project.index', params: { projectId: project.id } }">
dpschen commented 2023-03-28 14:07:14 +00:00
Outdated
Review
Copy Link

Shouldn't we still show the parent here?

Shouldn't we still show the parent here?
konrad commented 2023-03-28 15:47:20 +00:00
Outdated
Review
Copy Link

I've changed it now so that is shows this:

Screenshot_20230328_174428.png

(each project is clickable individually)

For a hierarchy like this:

Screenshot_20230328_174646.png

I've changed it now so that is shows this: ![Screenshot_20230328_174428.png](/attachments/35babb55-b48a-49bf-a595-3fcc28da12dc) (each project is clickable individually) For a hierarchy like this: ![Screenshot_20230328_174646.png](/attachments/070d677e-d199-45ee-af6b-c0a6b3196681)
dpschen commented 2023-03-28 16:32:34 +00:00
Outdated
Review
Copy Link

Can't see these images either

Can't see these images either
konrad commented 2023-03-28 19:20:18 +00:00
Outdated
Review
Copy Link

Again 404?

Again 404?
👍 1
konrad commented 2023-03-28 19:20:29 +00:00
Outdated
Review
Copy Link

This starts to feel like a gitea bug...

This starts to feel like a gitea bug...
👍 1
{{ getProjectTitle(project) }}
</router-link>
<template v-for="p in getAllParentProjects(project)">
dpschen commented 2023-04-11 16:27:58 +00:00
Outdated
Review
Copy Link

This won't update dynamically. Should we change the getParentProjects to a computed parentProjects that automatically updates instead?

This won't update dynamically. Should we change the `getParentProjects` to a computed `parentProjects` that automatically updates instead?
konrad commented 2023-04-12 10:28:14 +00:00
Outdated
Review
Copy Link

I tried to change it but it fails with getAncestors is not a function. Any idea?

I tried to change it but it fails with `getAncestors is not a function`. Any idea?
konrad commented 2023-04-12 10:29:35 +00:00
Outdated
Review
Copy Link

Actually this does update dynamically when the project changes. I've had a task open, moved the project to another parent project and it updated instantly.

Actually this does update dynamically when the project changes. I've had a task open, moved the project to another parent project and it updated instantly.
<router-link :to="{ name: 'project.index', params: { projectId: p.id } }">
{{ getProjectTitle(p) }}
</router-link>
<span class="has-text-grey-light" v-if="p.id !== project.id"> &gt; </span>
dpschen commented 2023-04-11 16:29:45 +00:00
Outdated
Review
Copy Link

Don't end with the error sign. Only use it in between two ancestors or as separator to task title if the latter is direclty next to it.

Don't end with the error sign. Only use it in between two ancestors or as separator to task title if the latter is direclty next to it.
konrad commented 2023-04-12 10:24:46 +00:00
Outdated
Review
Copy Link

But that's what this does?

But that's what this does?
</template>
</h6>
<checklist-summary :task="task"/>
@ -781,6 +784,19 @@ async function setPercentDone(percentDone: number) {
task: newTask,
})
}
function getAllParentProjects(project: IProject): IProject[] {
let parents = []
if (project.parentProjectId) {
const parentProject = projectStore.getProjectById(project.parentProjectId)
parents = getAllParentProjects(parentProject)
}
return [
...parents,
project,
]
}
</script>
<style lang="scss" scoped>