feature/projects-all-the-way-down #3323
|
@ -25,6 +25,7 @@
|
|||
:is-loading="projectUpdating[project.id]"
|
||||
:can-collapse="canCollapse"
|
||||
:level="level"
|
||||
|
||||
:data-project-id="project.id"
|
||||
/>
|
||||
</template>
|
||||
</draggable>
|
||||
|
|
|
@ -2,7 +2,6 @@
|
|||
<li
|
||||
class="list-menu loader-container is-loading-small"
|
||||
:class="{'is-loading': isLoading}"
|
||||
:data-project-id="project.id"
|
||||
>
|
||||
dpschen marked this conversation as resolved
Outdated
dpschen
commented
Set from outside, since this id is related to the sorting. Set from outside, since this id is related to the sorting.
konrad
commented
Done Done
|
||||
<div>
|
||||
<BaseButton
|
||||
dpschen marked this conversation as resolved
Outdated
dpschen
commented
Replace section with We'll add correct semantics here later (e.g. https://www.w3.org/WAI/ARIA/apg/patterns/menubar/examples/menubar-navigation/). Replace section with `<div>`.
We'll add correct semantics here later (e.g. https://www.w3.org/WAI/ARIA/apg/patterns/menubar/examples/menubar-navigation/). `<section>` is not correct though, since there is no headline.
konrad
commented
Done Done
|
||||
|
|
Reference in New Issue
Block a user
Since this block doesn't have a headline it shouldn't be a
<section>
. Maybe use<nav>
instead (nesting is allowed!)Move this whole block in a new
ProjectNavigationItem.vue
component. Reduces also the whole complexity withchildProjects[p.id]
because we can pass only the project.Done
Shouldn't a
nav
hold multiple navigation items?Yes! Sry I misread the position, where the
<section>
is.Okay you moved now only the item without the list below inside.
What i meant was:
<li>
insideProjectsNavigationItem.vue
.ProjectsNavigation.vue
is then used inside ProjectsNavigationItemThis whole block can then be simplified:
Because we can save the collapsed state inside each item we don't need to manage a list anymore.
So we don't even need the
<section>
then and can instead use the<li>
.It's totally fine to not group the buttons etc because they are already grouped by the
<li>
they are in. TheProjectsNavigation
component would be the last child insieProjectsNavigationItem
That makes sense. I've moved most of the logic over, as you suggested.
We actually need this (or another element) because the
section
is a flexbox container for the project title and related buttons. We can't use theli
as the flexbox container because the ProjectsNavigation for the child projects needs to stay below the project title etc. If it was in the same flexbox container it would get pushed to the right.