vikunja/frontend
Archived
6
39
Fork 48
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feature/projects-all-the-way-down #3323

Merged
konrad merged 123 commits from feature/projects-all-the-way-down into main 2023-05-30 10:09:40 +00:00
Conversation 16 Commits 123 Files Changed 85 +6 -6
2 changed files with 6 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 9b10693172 - Show all commits

6
src/components/home/ProjectsNavigationItem.vue
View File

@ -4,7 +4,7 @@
:class="{'is-loading': isLoading}"
:data-project-id="project.id"
dpschen marked this conversation as resolved Outdated
dpschen commented 2023-04-02 23:03:51 +00:00
Outdated
Review
Copy Link

Set from outside, since this id is related to the sorting.

Set from outside, since this id is related to the sorting.
✅ 1
konrad commented 2023-04-10 19:01:13 +00:00
Outdated
Review
Copy Link

Done

Done
>
<section>
<div>
dpschen marked this conversation as resolved Outdated
dpschen commented 2023-04-02 23:00:20 +00:00
Outdated
Review
Copy Link

Replace section with <div>.

We'll add correct semantics here later (e.g. https://www.w3.org/WAI/ARIA/apg/patterns/menubar/examples/menubar-navigation/). <section> is not correct though, since there is no headline.

Replace section with `<div>`. We'll add correct semantics here later (e.g. https://www.w3.org/WAI/ARIA/apg/patterns/menubar/examples/menubar-navigation/). `<section>` is not correct though, since there is no headline.
✅ 1
konrad commented 2023-04-10 19:00:58 +00:00
Outdated
Review
Copy Link

Done

Done
<BaseButton
v-if="canCollapse && childProjects?.length > 0"
@click="childProjectsOpen = !childProjectsOpen"
@ -44,7 +44,7 @@
</template>
</ProjectSettingsDropdown>
<span class="list-setting-spacer" v-else></span>
</section>
</div>
<ProjectsNavigation
v-if="canNestDeeper && childProjectsOpen && canCollapse"
dpschen commented 2023-04-02 22:58:31 +00:00
Outdated
Review
Copy Link

Use Expandable component for this.

Use `Expandable` component for this.
konrad commented 2023-04-10 19:00:38 +00:00
Outdated
Review
Copy Link

This seems to completly break the styling. I changed it to match the selectors but it still does not work. Not sure what to do about this.-

This seems to completly break the styling. I changed it to match the selectors but it still does not work. Not sure what to do about this.-
dpschen commented 2023-04-11 14:26:34 +00:00
Outdated
Review
Copy Link

I created an example how to use this in 51e29af010. I was unsure which parts parts should be dynamically be filled (via the open prop) or static (not rendering the Expandable at all via v-if).

I created an example how to use this in https://kolaente.dev/vikunja/frontend/commit/51e29af010defc5f6c46f85dbb7311904a7d40e1. I was unsure which parts parts should be dynamically be filled (via the `open` prop) or static (not rendering the `Expandable` at all via `v-if`).
v-model="childProjects"
@ -120,7 +120,7 @@ const canNestDeeper = computed(() => {
}
}
.list-menu:hover > section > .favorite {
.list-menu:hover > div > .favorite {
opacity: 1;
}
</style>

6
src/styles/theme/navigation.scss
View File

@ -19,7 +19,7 @@
padding: 0;
&.other-menu-items li,
li > section {
li > div {
height: 44px;
display: flex;
align-items: center;
@ -29,7 +29,7 @@
}
}
li > section {
li > div {
.menu-list-dropdown {
opacity: 1;
transition: $transition;
@ -76,7 +76,7 @@
}
.list-menu-link,
li, li > section {
li, li > div {
.collapse-project-button {
padding: .5rem .25rem .5rem .5rem;