vikunja/frontend
Archived
6
39
Fork 48
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feature/projects-all-the-way-down #3323

Merged
konrad merged 123 commits from feature/projects-all-the-way-down into main 2023-05-30 10:09:40 +00:00
Conversation 16 Commits 123 Files Changed 85 +1 -2
1 changed files with 1 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit afaf1846ec - Show all commits

3
src/views/Home.vue
View File

@ -32,7 +32,7 @@
<ProjectCardGrid :projects="projectHistory" v-cy="'projectCardGrid'" />
</div>
<ShowTasks
v-if="hasProjects"
v-if="projectStore.hasProjects"
class="show-tasks"
:key="showTasksKey"
/>
@ -80,7 +80,6 @@ const projectHistory = computed(() => {
const migratorsEnabled = computed(() => configStore.availableMigrators?.length > 0)
const hasTasks = computed(() => baseStore.hasTasks)
const hasProjects = computed(() => projectStore.hasProjects)
const loading = computed(() => taskStore.isLoading)
konrad marked this conversation as resolved Outdated
dpschen commented 2023-03-28 14:01:31 +00:00
Outdated
Review
Copy Link

This should be a computed of the store, like hasTasks.
Shouldn't we check the length here (projectStore.projects?.length)?

This should be a computed of the store, like `hasTasks`. Shouldn't we check the length here (`projectStore.projects?.length`)?
konrad commented 2023-03-28 14:25:58 +00:00
Outdated
Review
Copy Link

projects is an object, so checking the length of it won't work.

`projects` is an object, so checking the length of it won't work.
konrad commented 2023-03-28 14:27:20 +00:00
Outdated
Review
Copy Link

Moved it to the store.

Moved it to the store.
dpschen commented 2023-03-28 14:38:29 +00:00
Outdated
Review
Copy Link

Then Object.keys?.length

Then `Object.keys?.length`
konrad commented 2023-03-28 14:51:52 +00:00
Outdated
Review
Copy Link

Then Object.keys?.length

Wouldn't that cause a call to Object.keys? I think my solution is faster.

> Then `Object.keys?.length` Wouldn't that cause a call to `Object.keys`? I think my solution is faster.
konrad commented 2023-03-28 15:24:05 +00:00
Outdated
Review
Copy Link

Checked it: https://jsbench.me/hslfseq93y/1

Using Object.keys really is slower, and by a lot.

Checked it: https://jsbench.me/hslfseq93y/1 Using `Object.keys` really is slower, and by a lot.
dpschen commented 2023-03-28 16:10:17 +00:00
Outdated
Review
Copy Link

True. Using a Map with size would probably be the perfect solution here. But that is something for another time.

True. Using a Map with size would probably be the perfect solution here. But that is something for another time.
👍 1
dpschen commented 2023-04-11 16:08:22 +00:00
Outdated
Review
Copy Link

Don't wrap computed in computed. use projectStore.hasProjects directly

Don't wrap computed in computed. use `projectStore.hasProjects` directly
konrad commented 2023-04-12 09:56:19 +00:00
Outdated
Review
Copy Link

Done

Done
const deletionScheduledAt = computed(() => parseDateOrNull(authStore.info?.deletionScheduledAt))