vikunja/frontend
Archived
6
39
Fork 48
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feature/projects-all-the-way-down #3323

Merged
konrad merged 123 commits from feature/projects-all-the-way-down into main 2023-05-30 10:09:40 +00:00
Conversation 16 Commits 123 Files Changed 85 +2 -3
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit be1f1d94c9 - Show all commits

5
src/components/home/ProjectsNavigation.vue
View File

@ -72,7 +72,7 @@
</template>
<script lang="ts" setup>
import {ref, computed, watch, onActivated} from 'vue'
import {ref, computed, watch} from 'vue'
import draggable from 'zhyswan-vuedraggable'
import type {SortableEvent} from 'sortablejs'
@ -106,13 +106,12 @@ const currentProject = computed(() => baseStore.currentProject)
// TODO: child projects
const availableProjects = ref<IProject[]>([])
watch(
dpschen commented 2023-04-11 15:08:09 +00:00
Outdated
Review
Copy Link

Really unsure here: Since we do map data directly from the store I'm unsure if we should emit and update the store. Because an emit will change data in the parent. An update from the store will probably as well.

Really unsure here: Since we do map data directly from the store I'm unsure if we should emit _and_ update the store. Because an emit will change data in the parent. An update from the store will probably as well.
konrad commented 2023-04-12 08:49:51 +00:00
Outdated
Review
Copy Link

It looks like it works fine without the emit. We're always binding with :modelValue instead of v-model anyway…

It looks like it works fine without the emit. We're always binding with `:modelValue` instead of `v-model` anyway…
props.projects,
() => props.projects,
projects => {
availableProjects.value = projects
},
{immediate: true},
dpschen marked this conversation as resolved Outdated
dpschen commented 2023-04-01 16:13:07 +00:00
Outdated
Review
Copy Link

What consequence has this?

What consequence has this?
✅ 1
konrad commented 2023-04-01 20:04:13 +00:00
Outdated
Review
Copy Link

This now works, it didn't in an earlier version. I've removed the comment.

This now works, it didn't in an earlier version. I've removed the comment.
)
dpschen marked this conversation as resolved Outdated
dpschen commented 2023-04-01 16:15:30 +00:00
Outdated
Review
Copy Link

What exactly needs to be done for child projects?

What exactly needs to be done for child projects?
✅ 1
konrad commented 2023-04-01 19:48:57 +00:00
Outdated
Review
Copy Link

That was an old comment, I've removed it

That was an old comment, I've removed it
onActivated(() => availableProjects.value = props.projects)
const projectUpdating = ref<{ [id: IProject['id']]: boolean }>({})