vikunja/frontend
Archived
6
39
Fork 48
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feature/projects-all-the-way-down #3323

Merged
konrad merged 123 commits from feature/projects-all-the-way-down into main 2023-05-30 10:09:40 +00:00
Conversation 16 Commits 123 Files Changed 85 +2 -2
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit d414b65e7d - Show all commits

4
src/stores/projects.ts
View File

@ -36,8 +36,8 @@ export const useProjectStore = defineStore('project', () => {
.filter(p => !p.isArchived && p.isFavorite))
const hasProjects = computed(() => projects.value ? true : false)
dpschen commented 2023-04-11 15:28:24 +00:00
Outdated
Review
Copy Link

Since projects is of type object (defined by its type) this shouldn't work because !!{} === true.
Even if it would be undefined or null sometimes this should use Boolean(projects.value) for clarity instead.

Afaik there is no way around something like:

computed(() => Boolean(projectsArray.value.length))
Since `projects` is of type object (defined by its type) this shouldn't work because `!!{} === true`. Even if it would be undefined or null sometimes this should use `Boolean(projects.value)` for clarity instead. Afaik there is no way around something like: ```ts computed(() => Boolean(projectsArray.value.length)) ```
✅ 1
konrad commented 2023-04-12 09:31:25 +00:00
Outdated
Review
Copy Link

Fixed.

Fixed.
const getChildProjects = computed(() => {
return (id: IProject['id']) => projectsArray.value.filter(p => p.parentProjectId === id) || []
const getChildProjects = computed<IProject[]>(() => {
dpschen commented 2023-04-11 15:16:53 +00:00
Outdated
Review
Copy Link

This computed seems really unnecessary. Reason: We can achieve the same (and faster) by using: projects.value[id]. Since projects is exported we should replace uses of this computed. We might need to create new simple computeds where used. Depending on usecase something like

const myProject = computed(() => projects.value[myProjectId.value])
This computed seems really unnecessary. Reason: We can achieve the same (and faster) by using: `projects.value[id]`. Since `projects` is exported we should replace uses of this computed. We might need to create new simple computeds where used. Depending on usecase something like ```ts const myProject = computed(() => projects.value[myProjectId.value]) ```
konrad commented 2023-04-12 09:14:50 +00:00
Outdated
Review
Copy Link

We've actually been using computed for most uses of the store computed anyway. I've changed it to use the projects property of the store directly.

We've actually been using computed for most uses of the store computed anyway. I've changed it to use the `projects` property of the store directly.
return (id: IProject['id']) => projectsArray.value.filter(p => p.parentProjectId === id)
})
const findProjectByExactname = computed(() => {
konrad marked this conversation as resolved Outdated
dpschen commented 2023-04-11 15:18:55 +00:00
Outdated
Review
Copy Link

The fallback is unnecessary OR the type of the projects ref is wrong. Because Object.values on an object should always return an array.

The fallback is unnecessary OR the type of the projects ref is wrong. Because `Object.values` on an object should always return an array.
konrad commented 2023-04-12 09:16:28 +00:00
Outdated
Review
Copy Link

The type is correct. I've removed the fallback.

The type is correct. I've removed the fallback.
dpschen commented 2023-04-12 15:18:22 +00:00
Outdated
Review
Copy Link

The new type on the computed is wrong. The computed returns a function that returns IProject[]. So the correct type is probably (id: IProject['id']) => IProject[].

But that should be automatically inferred by the returned function. If it is not inferreed, annotate the returned function instead and remove the type annotation of the computed.

The new type on the computed is wrong. The computed returns a function that returns `IProject[]`. So the correct type is probably `(id: IProject['id']) => IProject[]`. But that should be automatically inferred by the returned function. If it is not inferreed, annotate the returned function instead and remove the type annotation of the computed.
konrad commented 2023-04-14 15:43:27 +00:00
Outdated
Review
Copy Link

Should be fixed now.

Should be fixed now.