vikunja/frontend
Archived
6
39
Fork 48
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feature/projects-all-the-way-down #3323

Merged
konrad merged 123 commits from feature/projects-all-the-way-down into main 2023-05-30 10:09:40 +00:00
Conversation 16 Commits 123 Files Changed 85 +12 -16
2 changed files with 12 additions and 16 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit ddcd6a17dc - Show all commits

2
src/components/home/ProjectsNavigationWrapper.vue
View File

@ -24,7 +24,7 @@ const favoriteProjects = computed(() => projectStore.favoriteProjects
</script>
<style lang="scss" scoped>
konrad marked this conversation as resolved Outdated
dpschen commented 2023-03-29 15:46:04 +00:00
Outdated
Review
Copy Link

Probably because you use v-model instead of modelValue for ProjectsNavigation. I guess that when the template gets rendered it wants to bind to something like @update:modelValue="(newVal) => projects.value = newVal"

Probably because you use `v-model` instead of `modelValue` for ProjectsNavigation. I guess that when the template gets rendered it wants to bind to something like `@update:modelValue="(newVal) => projects.value = newVal"`
konrad commented 2023-04-01 09:23:36 +00:00
Outdated
Review
Copy Link

I've now changed it to :modelValue and that seems to work.

I've now changed it to `:modelValue` and that seems to work.
.menu {
.menu + .menu{
padding-top: math.div($navbar-padding, 2);
konrad marked this conversation as resolved Outdated
dpschen commented 2023-03-29 15:47:36 +00:00
Outdated
Review
Copy Link

favoriteProjects also seems like something a store should export.

`favoriteProjects` also seems like something a store should export.
konrad commented 2023-04-01 09:18:18 +00:00
Outdated
Review
Copy Link

Done

Done
dpschen commented 2023-04-01 16:25:41 +00:00
Outdated
Review
Copy Link

The top menu shouldn't have a padding top that has the sole purpose of creating space to the silbling component above. Since I still only check the code and don't have this branch running locally I'm not sure if the padding extends the background or something like that instead.

If not this .menu should use margin-top:

.menu + .menu {
	margin-top: math.div($navbar-padding, 2);
}
The top menu shouldn't have a padding top that has the sole purpose of creating space to the silbling component above. Since I still only check the code and don't have this branch running locally I'm not sure if the padding extends the background or something like that instead. If not this `.menu` should use margin-top: ```scss .menu + .menu { margin-top: math.div($navbar-padding, 2); } ```
✅ 1
konrad commented 2023-04-01 19:52:59 +00:00
Outdated
Review
Copy Link

Done.

Done.
}
</style>
konrad marked this conversation as resolved Outdated
dpschen commented 2023-03-29 15:48:20 +00:00
Outdated
Review
Copy Link

Why the mapping / returning of a copy?

Why the mapping / returning of a copy?
konrad commented 2023-04-01 09:16:22 +00:00
Outdated
Review
Copy Link

That was a relic, I've removed it now.

That was a relic, I've removed it now.

26
src/components/home/navigation.vue
View File

@ -112,23 +112,19 @@ const menuActive = computed(() => baseStore.menuActive)
}
}
.top-menu {
margin-top: math.div($navbar-padding, 2);
.top-menu .menu-list {
li {
dpschen commented 2023-04-01 12:49:52 +00:00
Outdated
Review
Copy Link

Remove outer margin set from inside the component and add it from outside instead.

Remove outer margin set from inside the component and add it from outside instead.
font-weight: 600;
font-family: $vikunja-font;
}
.menu-list {
li {
font-weight: 600;
font-family: $vikunja-font;
}
.list-menu-link,
li > a {
padding-left: 2rem;
display: inline-block;
.list-menu-link,
li > a {
padding-left: 2rem;
display: inline-block;
.icon {
padding-bottom: .25rem;
}
.icon {
padding-bottom: .25rem;
}
}
}