vikunja/frontend
Archived
6
39
Fork 48
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feature/projects-all-the-way-down #3323

Merged
konrad merged 123 commits from feature/projects-all-the-way-down into main 2023-05-30 10:09:40 +00:00
Conversation 16 Commits 123 Files Changed 85 +3 -3
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit e4d97e0520 - Show all commits

2
src/stores/base.ts
View File

@ -81,7 +81,7 @@ export const useBaseStore = defineStore('base', () => {
async function handleSetCurrentProject(
{project, forceUpdate = false}: {project: IProject | null, forceUpdate?: boolean},
) {
if (project === null) {
if (project === null || typeof project === 'undefined') {
setCurrentProject({})
setBackground('')
setBlurHash('')

4
src/views/tasks/TaskDetailView.vue
View File

@ -18,7 +18,7 @@
<router-link :to="{ name: 'project.index', params: { projectId: p.id } }">
{{ getProjectTitle(p) }}
</router-link>
<span class="has-text-grey-light" v-if="p.id !== project.id"> &gt; </span>
<span class="has-text-grey-light" v-if="p.id !== project?.id"> &gt; </span>
dpschen commented 2023-04-11 16:29:45 +00:00
Outdated
Review
Copy Link

Don't end with the error sign. Only use it in between two ancestors or as separator to task title if the latter is direclty next to it.

Don't end with the error sign. Only use it in between two ancestors or as separator to task title if the latter is direclty next to it.
konrad commented 2023-04-12 10:24:46 +00:00
Outdated
Review
Copy Link

But that's what this does?

But that's what this does?
</template>
</h6>
@ -539,7 +539,7 @@ const visible = ref(false)
konrad marked this conversation as resolved Outdated
dpschen commented 2023-04-11 16:32:49 +00:00
Outdated
Review
Copy Link

getProjectById returns undefined if there is no project with that id. So why not use that directly?

`getProjectById` returns `undefined` if there is no project with that id. So why not use that directly?
konrad commented 2023-04-12 10:31:31 +00:00
Outdated
Review
Copy Link

Done

Done
const taskId = toRef(props, 'taskId')
const project = computed(() => task.projectId ? projectStore.projects[task.projectId] : null)
const project = computed(() => projectStore.projects[task.projectId])
watchEffect(() => {
baseStore.handleSetCurrentProject({
project: project.value,