vikunja/frontend
Archived
6
39
Fork 48
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feature/projects-all-the-way-down #3323

Merged
konrad merged 123 commits from feature/projects-all-the-way-down into main 2023-05-30 10:09:40 +00:00
Conversation 16 Commits 123 Files Changed 85 +13 -1
1 changed files with 13 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit f7629c28f4 - Show all commits

14
src/stores/projects.ts
View File

@ -72,7 +72,19 @@ export const useProjectStore = defineStore('project', () => {
// if the project is a child project, we need to also set it in the parent
if (project.parentProjectId) {
dpschen commented 2023-03-28 13:52:42 +00:00
Outdated
Review
Copy Link

See comment about having the data as sub projects from earlier.

See comment about having the data as sub projects from earlier.
const parent = projects.value[project.parentProjectId]
parent.childProjects = parent.childProjects?.map(p => p.id === project.id ? project : p)
let foundProject = false
parent.childProjects = parent.childProjects?.map(p => {
dpschen commented 2023-04-11 15:23:40 +00:00
Outdated
Review
Copy Link

The three lines above should be called via a deep watcher on the current project. Not as a side effect.

The three lines above should be called via a deep watcher on the current project. Not as a side effect.
konrad commented 2023-04-12 09:30:19 +00:00
Outdated
Review
Copy Link

You mean setting the current project in the base store?

You mean setting the current project in the base store?
dpschen commented 2023-04-12 15:12:18 +00:00
Outdated
Review
Copy Link

I mean:

  1. remove this sideeffect of the setProject function:
if (baseStore.currentProject?.id === project.id) {
	baseStore.setCurrentProject(project)
}
  1. Instead add a watcher on the project that has the id of the current project.
watchEffect(() => baseStore.setCurrentProject(projects.value[baseStore.currentProject.id])
)

It might be even better to make the currentProject a computed based on the store instead and only setting it via id (unsure here how to handle projects that are not saved yet)

I mean: 1) remove this sideeffect of the `setProject` function: ``` if (baseStore.currentProject?.id === project.id) { baseStore.setCurrentProject(project) } ``` 2) Instead add a watcher on the project that has the id of the current project. ```ts watchEffect(() => baseStore.setCurrentProject(projects.value[baseStore.currentProject.id]) ) ``` It might be even better to make the currentProject a computed based on the store instead and only setting it via id (unsure here how to handle projects that are not saved yet)
konrad commented 2023-04-14 15:41:42 +00:00
Outdated
Review
Copy Link

I've now changed it to use a watcher.

It might be even better to make the currentProject a computed based on the store instead and only setting it via id (unsure here how to handle projects that are not saved yet)

That sounds like a good idea, but let's push that to another PR.

I've now changed it to use a watcher. > It might be even better to make the currentProject a computed based on the store instead and only setting it via id (unsure here how to handle projects that are not saved yet) That sounds like a good idea, but let's push that to another PR.
konrad commented 2023-04-14 15:41:44 +00:00
Outdated
Review
Copy Link

I've now changed it to use a watcher.

It might be even better to make the currentProject a computed based on the store instead and only setting it via id (unsure here how to handle projects that are not saved yet)

That sounds like a good idea, but let's push that to another PR.

I've now changed it to use a watcher. > It might be even better to make the currentProject a computed based on the store instead and only setting it via id (unsure here how to handle projects that are not saved yet) That sounds like a good idea, but let's push that to another PR.
if(p.id === project.id) {
foundProject = true
return project
}
return p
})
// If we hit this, the project now has a new parent project which it did not have before
if (!foundProject) {
parent.childProjects.push(project)
}
setProject(parent, false)
}
}