vikunja/frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

Added hotkeys for priority, delete and favorite on the TaskDetailView #3400

Merged
konrad merged 5 commits from primeapple/frontend:add-hotkeys-for-priority-and-delete into main 2023-05-10 09:14:08 +00:00
Conversation 3 Commits 5 Files Changed 3 +12 -12
1 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 9dfaabc0b3 - Show all commits

24
src/components/misc/keyboard-shortcuts/shortcuts.ts
View File

@ -140,18 +140,18 @@ export const KEYBOARD_SHORTCUTS : ShortcutGroup[] = [
title: 'keyboardShortcuts.task.description',
keys: ['e'],
},
{
title: 'keyboardShortcuts.task.priority',
keys: ['p'],
},
{
title: 'keyboardShortcuts.task.delete',
keys: ['x'],
},
{
title: 'keyboardShortcuts.task.favorite',
keys: ['s'],
},
{
title: 'keyboardShortcuts.task.priority',
keys: ['p'],
},
{
title: 'keyboardShortcuts.task.delete',
keys: ['x'],
},
{
title: 'keyboardShortcuts.task.favorite',
keys: ['s'],
},
konrad marked this conversation as resolved Outdated
konrad commented 2023-04-24 10:58:01 +00:00
Outdated
Review
Copy Link

Please format this using tabs so that it's consistent with the rest of the document (why didn't the linter catch it?)

Please format this using tabs so that it's consistent with the rest of the document (why didn't the linter catch it?)
primeapple commented 2023-04-26 11:20:09 +00:00
Outdated
Review
Copy Link

The problem here is, that the .editorconfig actually wants 2 spaces indentation for .json files.

As for the reason why the Linter doesn't catch this:
The lint task in package.json only runs for .vue,.js,.ts files, not for json ones.

I wonder why you haven't set up prettier? Or even better rome (unsure if it works with vue files, tho).

~~The problem here is, that the `.editorconfig` actually wants 2 spaces indentation for `.json` files.~~ ~~As for the reason why the Linter doesn't catch this: The `lint` task in `package.json` only runs for `.vue,.js,.ts` files, not for `json` ones.~~ I wonder why you haven't set up prettier? Or even better [rome](https://rome.tools/) (unsure if it works with `vue` files, tho).
primeapple commented 2023-04-26 11:25:06 +00:00
Outdated
Review
Copy Link

Fixed it :)

Fixed it :)
konrad commented 2023-04-26 13:25:46 +00:00
Outdated
Review
Copy Link

We have a PR which got kind of stale: #930

Rome looks interesting though!

We have a PR which got kind of stale: https://kolaente.dev/vikunja/frontend/pulls/930 Rome looks interesting though!
👍 1
],
},
]