vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: defer everything until the api config is loaded #926

Merged
konrad merged 27 commits from feature/ready-state into main 2021-11-13 19:49:03 +00:00
Conversation 3 Commits 27 Files Changed 10 +6 -4
2 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 15a6e52815 - Show all commits

8
src/App.vue
View File

@ -2,10 +2,10 @@
<ready>
<div :class="{'is-touch': isTouch}">
<div :class="{'is-hidden': !online}">
<!-- This is a workaround to get the sw to "see" the to-be-cached version of the offline background image -->
<div class="offline" style="height: 0;width: 0;"></div>
<top-navigation v-if="authUser"/>
<content-auth v-if="authUser"/>
<template v-if="authUser">
<top-navigation/>
<content-auth/>
konrad marked this conversation as resolved Outdated
dpschen commented 2021-11-04 15:31:39 +00:00
Outdated
Review
Copy Link

Wrap in <template v-if="authUser">

Wrap in `<template v-if="authUser">`
konrad commented 2021-11-10 18:52:17 +00:00
Outdated
Review
Copy Link

Why?

Why?
dpschen commented 2021-11-10 19:06:03 +00:00
Outdated
Review
Copy Link

to make clear that it mounts at the same time than the content-auth below.

to make clear that it mounts at the same time than the content-auth below.
konrad commented 2021-11-10 19:16:53 +00:00
Outdated
Review
Copy Link

Ah, that makes sense. Done.

Ah, that makes sense. Done.
</template>
<content-link-share v-else-if="authLinkShare"/>
<content-no-auth v-else/>
<notification/>

2
src/components/misc/ready.vue
View File

@ -1,4 +1,6 @@
<template>
<!-- This is a workaround to get the sw to "see" the to-be-cached version of the offline background image -->
<div class="offline" style="height: 0;width: 0;"></div>
<div class="app offline" v-if="!online">
<div class="offline-message">
<h1>{{ $t('offline.title') }}</h1>