vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: defer everything until the api config is loaded #926

Merged
konrad merged 27 commits from feature/ready-state into main 2021-11-13 19:49:03 +00:00
Conversation 3 Commits 27 Files Changed 10 +1
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 385f2a9a5e - Show all commits

1
src/components/misc/api-config.vue
View File

@ -88,6 +88,7 @@ export default {
methods: {
async setApiUrl() {
if (this.apiUrl === '') {
// Don't try to check and set an empty url
konrad marked this conversation as resolved Outdated
dpschen commented 2021-11-04 15:44:56 +00:00
Outdated
Review
Copy Link

Explain why we return here

Explain why we return here
konrad commented 2021-11-10 19:01:43 +00:00
Outdated
Review
Copy Link

Done.

Done.
return
konrad marked this conversation as resolved Outdated
dpschen commented 2021-11-10 20:45:01 +00:00
Outdated
Review
Copy Link

That seems like it should throw an error?

That seems like it should throw an error?
konrad commented 2021-11-10 21:17:14 +00:00
Outdated
Review
Copy Link

It does yeah. I've modified it so it shows an error with a "good" error message to the user instead of throwing one.

It does yeah. I've modified it so it shows an error with a "good" error message to the user instead of throwing one.
}