vikunja
/
frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

feat: defer everything until the api config is loaded #926

Merged
konrad merged 27 commits from feature/ready-state into main 2021-11-13 19:49:03 +00:00
Conversation 3 Commits 27 Files Changed 10 +1
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit f2c8cdd3be - Show all commits

1
src/components/misc/api-config.vue
View File

@ -96,6 +96,7 @@ export default {
const url = await checkAndSetApiUrl(this.apiUrl, () => this.$store.dispatch('config/update'))
if (url === '') {
konrad marked this conversation as resolved
dpschen commented 2021-11-04 15:45:07 +00:00
Review
Copy Link

Explain why we return here

Explain why we return here
// If the config setter function could not figure out a url
return
konrad marked this conversation as resolved Outdated
dpschen commented 2021-11-10 20:45:12 +00:00
Outdated
Review
Copy Link

That seems like it should throw an error? (2)

That seems like it should throw an error? (2)
}