vikunja/frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

Migrate to bulma-css-variables and introduce dark mode #954

Merged
konrad merged 72 commits from adrinux/frontend:bulma-css-variables into main 2021-11-22 21:12:55 +00:00
Conversation 24 Commits 72 Files Changed 73 +2 -3
1 changed files with 2 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 54f1271ab9 - Show all commits

5
src/views/list/views/Kanban.vue
View File

@ -593,7 +593,6 @@ export default {
</script>
<style lang="scss">
$bucket-background: var(--grey-100);
$ease-out: all .3s cubic-bezier(0.23, 1, 0.32, 1);
$bucket-width: 300px;
$bucket-header-height: 60px;
@ -636,7 +635,7 @@ $filter-container-height: '1rem - #{$switch-view-height}';
}
.bucket {
background-color: $bucket-background;
background-color: var(--grey-100);
border-radius: $radius;
adrinux marked this conversation as resolved Outdated
dpschen commented 2021-11-04 20:52:17 +00:00
Outdated
Review
Copy Link

This seems like a mistake: $bucket-background is still defined as SASS variable.
I think it makes sense to keep it that way: Compiled it will resolve in var(--grey-100) which seems fine

This seems like a mistake: `$bucket-background` is still defined as SASS variable. I think it makes sense to keep it that way: Compiled it will resolve in `var(--grey-100)` which seems fine
adrinux commented 2021-11-05 13:32:05 +00:00
Outdated
Review
Copy Link

Yep, reverted 0191f12db7

Though declaring it to be the same color as what's behind it seems pointless - hangover from previous kanban design?

Yep, reverted https://kolaente.dev/adrinux/frontend/commit/0191f12db76bf93bee91ea0e58dd7d52c2f423e4 Though declaring it to be the same color as what's behind it seems pointless - hangover from previous kanban design?
dpschen commented 2021-11-06 12:07:03 +00:00
Outdated
Review
Copy Link

@konrad: any idea?

@konrad: any idea?
konrad commented 2021-11-07 13:42:17 +00:00
Outdated
Review
Copy Link

It kind of comes from the kanban redesign, but is still required: When the list has a background, the buckets need to have a colored background.

It kind of comes from the kanban redesign, but is still required: When the list has a background, the buckets need to have a colored background.
konrad commented 2021-11-07 13:43:09 +00:00
Outdated
Review
Copy Link

I think we could remove the variable and swap its uses to use the same variable that's used for the overall site background.

I think we could remove the variable and swap its uses to use the same variable that's used for the overall site background.
dpschen commented 2021-11-07 14:11:45 +00:00
Outdated
Review
Copy Link

You mean the variable that was set for $bucket-background aka var(--grey-100)?

You mean the variable that was set for `$bucket-background` aka `var(--grey-100)`?
konrad commented 2021-11-07 14:13:35 +00:00
Outdated
Review
Copy Link

Yes.

Yes.
👍 1
adrinux commented 2021-11-08 15:27:06 +00:00
Outdated
Review
Copy Link

Removed $bucket-background 54f1271ab9

Removed $bucket-background https://kolaente.dev/adrinux/frontend/commit/54f1271ab935a5b0c93168378395c4093ac4f01b
👍 1
position: relative;
@ -685,7 +684,7 @@ $filter-container-height: '1rem - #{$switch-view-height}';
padding-right: 1rem;
.button {
background: $bucket-background;
background: var(--grey-100);
width: 100%;
adrinux marked this conversation as resolved Outdated
dpschen commented 2021-11-04 20:52:26 +00:00
Outdated
Review
Copy Link

Same here

Same here
adrinux commented 2021-11-05 13:32:16 +00:00
Outdated
Review
Copy Link

Reverted.

Reverted.
👍 1
}
}