vikunja/frontend
Archived
6
39
Fork 49
Code Issues 1 Pull Requests 4 Projects Releases 26 Activity

Migrate to bulma-css-variables and introduce dark mode #954

Merged
konrad merged 72 commits from adrinux/frontend:bulma-css-variables into main 2021-11-22 21:12:55 +00:00
Conversation 24 Commits 72 Files Changed 73 +10 -14
1 changed files with 10 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit 92b2010cdc - Show all commits

24
src/styles/variables/shadows.scss
View File

@ -7,20 +7,16 @@
0 3px 6px hsla(var(--grey-500-hsl), .08);
--shadow-lg: 0 15px 25px hsla(var(--grey-500-hsl), .12),
0 5px 10px hsla(var(--grey-500-hsl), .05);
// unused --shadow-xl: 0 20px 40px hsla(var(--grey-500-hsl), .2);
}
adrinux marked this conversation as resolved Outdated
dpschen commented 2021-11-04 20:49:29 +00:00
Outdated
Review
Copy Link

good catch!
I think we should either remove it or uncomment it. Like this doesn't make sense (?).

good catch! I think we should either remove it or uncomment it. Like this doesn't make sense (?).
adrinux commented 2021-11-05 13:19:05 +00:00
Outdated
Review
Copy Link

The comment was to spark exactly this conversation :)
Should I remove it?

It's not used. It's not overriding something declared by bulma.

I vote for remove...

The comment was to spark exactly this conversation :) Should I remove it? It's not used. It's not overriding something declared by bulma. I vote for remove...
dpschen commented 2021-11-06 12:08:00 +00:00
Outdated
Review
Copy Link

@konrad: do you remember the reason for shadow?

@konrad: do you remember the reason for shadow?
konrad commented 2021-11-07 13:40:50 +00:00
Outdated
Review
Copy Link

No real reason. When I added the shadows, I added a few variants to have a bit more flexibility. If it's not used anywhere I think it is fine to remove.

No real reason. When I added the shadows, I added a few variants to have a bit more flexibility. If it's not used anywhere I think it is fine to remove.
👍 1
adrinux commented 2021-11-08 15:04:45 +00:00
Outdated
Review
Copy Link

Removed shadow-xl 92b2010cdc

Removed shadow-xl https://kolaente.dev/adrinux/frontend/commit/92b2010cdc7912142105a401056ec200dd6356eb
👍 1
@media (prefers-color-scheme: dark) {
:root {
/* Even darker shadows for dark mode */
--shadow-xs: 0 1px 3px hsla(var(--grey-100-hsl),.12),
0 1px 2px hsla(var(--grey-100-hsl), .24);
--shadow-sm: 0 3px 6px hsla(var(--grey-100-hsl), .12),
0 2px 4px hsla(var(--grey-100-hsl), .10);
--shadow-md: 0 10px 20px hsla(var(--grey-100-hsl), .12),
0 3px 6px hsla(var(--grey-100-hsl), .08);
--shadow-lg: 0 15px 25px hsla(var(--grey-100-hsl), .12),
0 5px 10px hsla(var(--grey-100-hsl), .05);
// unused --shadow-xl: 0 20px 40px hsla(var(--grey-100-hsl), .2);
/* Even darker shadows for dark mode */
--shadow-xs: 0 1px 3px hsla(var(--grey-100-hsl),.12),
0 1px 2px hsla(var(--grey-100-hsl), .24);
adrinux marked this conversation as resolved Outdated
dpschen commented 2021-11-04 20:50:10 +00:00
Outdated
Review
Copy Link

Nest the @media so we don't need to repeat :root. (2)

Nest the `@media` so we don't need to repeat `:root`. (2)
adrinux commented 2021-11-05 12:59:55 +00:00
Outdated
Review
Copy Link

Done a258b938fa

Done https://kolaente.dev/adrinux/frontend/commit/a258b938fabdb69b30615897b157c37a020b4059
👍 1
--shadow-sm: 0 3px 6px hsla(var(--grey-100-hsl), .12),
0 2px 4px hsla(var(--grey-100-hsl), .10);
--shadow-md: 0 10px 20px hsla(var(--grey-100-hsl), .12),
0 3px 6px hsla(var(--grey-100-hsl), .08);
--shadow-lg: 0 15px 25px hsla(var(--grey-100-hsl), .12),
0 5px 10px hsla(var(--grey-100-hsl), .05);
}
}
}