Migrate to bulma-css-variables and introduce dark mode #954
|
@ -5,13 +5,13 @@
|
|||
// This imports are the same as in "bulma/bulma.sass"
|
||||
// with the expeption of the bulma utilities.
|
||||
// They are imported globally in variables.scss
|
||||
@import "bulma/sass/base/_all";
|
||||
@import "bulma/sass/elements/_all";
|
||||
@import "bulma/sass/form/_all";
|
||||
@import "bulma/sass/components/_all";
|
||||
@import "bulma/sass/grid/_all";
|
||||
@import "bulma/sass/helpers/_all";
|
||||
@import "bulma/sass/layout/_all";
|
||||
@import "bulma-css-variables/sass/base/_all";
|
||||
@import "bulma-css-variables/sass/elements/_all";
|
||||
@import "bulma-css-variables/sass/form/_all";
|
||||
@import "bulma-css-variables/sass/components/_all";
|
||||
@import "bulma-css-variables/sass/grid/_all";
|
||||
@import "bulma-css-variables/sass/helpers/_all";
|
||||
@import "bulma-css-variables/sass/layout/_all";
|
||||
|
||||
@import "theme";
|
||||
@import "components";
|
|
@ -3,10 +3,10 @@
|
|||
@import "variables";
|
||||
konrad marked this conversation as resolved
Outdated
|
||||
|
||||
// the default values get overwritten by the definitions above
|
||||
@import "bulma/sass/utilities/_all";
|
||||
@import "bulma-css-variables/sass/utilities/_all";
|
||||
|
||||
// this is needed so that the shared form variables are globally defined aswell
|
||||
@import "bulma/sass/form/shared";
|
||||
@import "bulma-css-variables/sass/form/shared";
|
||||
|
||||
// since $tablet is defined by bulma we can just define it after importing the utilities
|
||||
$mobile: math.div($tablet, 2);
|
Reference in New Issue
Block a user
The
@import "colors";
should be removed here and instead added inglobal.scss
below the bulma imports.Probably also below the
theme
andcomponents
overwrites, but I'm not 100% sure about that.Reason: the
colors.scss
produces now CSS output (the:root
rules) — it was compiled to nothing before.Since it's prefixed to every components rendered CSS this would result in a lot of code duplication in the end.
Probably not a big issue with gzip but still unnecessary.
Maybe we should rename it (maybe
custom-properties.scss
?) and move it out of this folder (the namevariables
stood for 'SCSS variables') so that we don't mix contexts, since all the other files inside are imported by this_index.scss
.#756 (comment)
I just realise that this might fix also the issue you had with
!important
.Yes, there is definitely a lot of duplication and yes I'm sure that's why I had to use !important so much (it seems to be used quite a lot in scss, not just by me!).
Wasn't clear to me if that was introduced by my changes or pre-existing. I have to say I feel like I'd need a couple of hours and to draw a flow chart to figure out the flow of all these imports :) That said it looks like there was already some cleanup recently.
Added an issue so I remember to try this.
I've just removed all the '!important' declarations in colors.scss I needed before with no ill effect.