Utilize bjw-s's common Helm library. #13

Merged
konrad merged 41 commits from :new-helm-chart into main 2023-11-07 14:47:24 +00:00
Showing only changes of commit 4909345cd1 - Show all commits

View File

@ -18,6 +18,55 @@ storage:
# VIKUNJA COMPONENTS #
######################
# You can find the default values
konrad marked this conversation as resolved Outdated

Doesn't this need a link to the docs with the default config?

Doesn't this need a link to the docs with the default config?

fixed

d8500214e9

fixed https://kolaente.dev/vikunja/helm-chart/commit/d8500214e98def13755bad78e31e9b2e39404df1
api:
enabled: true
image:
repository: vikunja/api
pullPolicy: IfNotPresent
persistence:
data:
enabled: true
# existingClaim: # your-claim
accessMode: ReadWriteOnce
size: 10Gi
# storageClass: storage-class
ingress:
main:
enabled: false
annotations:
# proxy-body-size is set to 0 to remove the body limit on file uploads
nginx.ingress.kubernetes.io/proxy-body-size: "0"
hosts:
- host: vikunja.local
konrad marked this conversation as resolved Outdated

Why vikunja.local?

Why `vikunja.local`?

The existing chart has “chart-example.local”, I figured that changing that to “vikunja.local” would be more Vikunja “branded”, if you will, lol.

I can change it back if you would prefer!

The existing chart has “chart-example.local”, I figured that changing that to “vikunja.local” would be more Vikunja “branded”, if you will, lol. I can change it back if you would prefer!

I'm fine with either but it should be clear that the value is only an example value and should be changed.

I'm fine with either but it should be clear that the value is only an example value and should be changed.
https://kolaente.dev/vikunja/helm-chart/commit/7d2f43fee3d21c2a5844ac71bcf54c7da96cf1b9
paths:
- path: "/api"
tls: []
configMaps:
# The configuration for Vikunja's backend.
# https://vikunja.io/docs/config-options/
config:
enabled: true
data:
config.yml:
database:
# You should provide your own secret outside of this helm-chart and use `postgresql.global.postgresql.auth.existingSecret` to provide credentials to the postgresql instance (https://github.com/bitnami/charts/blob/5ff8ad5f3c754e3c2423d6abf46f522e8abe0410/bitnami/postgresql/values.yaml#L35-L39)
type: 'postgres'
user: "{{ .Values.postgresql.global.postgresql.auth.username }}"
password: "{{ .Values.postgresql.global.postgresql.auth.password }}"
database: "{{ .Values.postgresql.global.postgresql.auth.database }}"
host: '{{ .Release.Name }}-postgresql'
service:
# Vikunja needs to know the frontend URL for password reset emails.
frontendUrl: http://vikunja.local
konrad marked this conversation as resolved Outdated

But the default value for this one is the one defined in the ingress, why define it here again?

But the default value for this one is the one defined in the ingress, why define it here again?

Fair, forgot to use the ingress value for that variable as well. I went ahead and fixed it. I also included a comment to to the user incase they aren't using an ingress resource (I was even using a Service behind a central Nginx until recently)

fixed!

Fair, forgot to use the `ingress` value for that variable as well. I went ahead and fixed it. I also included a comment to to the user incase they aren't using an `ingress` resource (I was even using a `Service` behind a central Nginx until recently) fixed!
https://kolaente.dev/vikunja/helm-chart/commit/9cd4680e707c57d06e718f8d1e6f524408965a32 and https://kolaente.dev/vikunja/helm-chart/commit/c601e5e449523ffb7feb7d35ca72389075769d9c
typesense:
# Typesense will only work if it is enabled below (typesense.enabled).
url: '{{ printf "%s-typesense" .Release.Name }}'
apiKey: "{{ .Values.typesense.env.TYPESENSE_API_KEY }}"
redis:
# Redis will only work if it is enabled below (redis.enabled).
host: '{{ printf "%s-redis-master" .Release.Name }}'
db: "{{ .Release.Name }}"
frontend:
enabled: true
# You can add any of the top-level keys in the common chart's `values.yaml` to override them here.
@ -53,53 +102,7 @@ frontend:
enabled: true
data: {}
api:
enabled: true
image:
repository: vikunja/api
pullPolicy: IfNotPresent
persistence:
data:
enabled: true
# existingClaim: # your-claim
accessMode: ReadWriteOnce
size: 10Gi
# storageClass: storage-class
ingress:
main:
enabled: false
annotations:
# proxy-body-size is set to 0 to remove the body limit on file uploads
nginx.ingress.kubernetes.io/proxy-body-size: "0"
hosts:
- host: vikunja.local
paths:
- path: "/api"
tls: []
configMaps:
# The configuration for Vikunja's backend.
# https://vikunja.io/docs/config-options/
config:
enabled: true
data:
database:
# You should provide your own secret outside of this helm-chart and use `postgresql.global.postgresql.auth.existingSecret` to provide credentials to the postgresql instance (https://github.com/bitnami/charts/blob/5ff8ad5f3c754e3c2423d6abf46f522e8abe0410/bitnami/postgresql/values.yaml#L35-L39)
type: 'postgres'
user: "{{ .Values.postgresql.global.postgresql.auth.username }}"
password: "{{ .Values.postgresql.global.postgresql.auth.password }}"
database: "{{ .Values.postgresql.global.postgresql.auth.database }}"
host: '{{ .Release.Name }}-postgresql'
service:
# Vikunja needs to know the frontend URL for password reset emails.
frontendUrl: http://vikunja.local
typesense:
# Typesense will only work if it is enabled below (typesense.enabled).
url: '{{ printf "%s-typesense" .Release.Name }}'
apiKey: "{{ .Values.typesense.env.TYPESENSE_API_KEY }}"
redis:
# Redis will only work if it is enabled below (redis.enabled).
host: '{{ printf "%s-redis-master" .Release.Name }}'
db: "{{ .Release.Name }}"
# env:
# VIKUNJA_FRONTEND_URL: http://vikunja.local/api