vikunja/helm-chart
2
2
Fork 5
Code Issues 7 Pull Requests 1 Packages Projects Releases 1 Wiki Activity

Utilize bjw-s's common Helm library. #13

Merged
konrad merged 41 commits from :new-helm-chart into main 2023-11-07 14:47:24 +00:00
Conversation 14 Commits 41 Files Changed 24 +8 -9
1 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files
Showing only changes of commit a3a944482e - Show all commits

17
values.yaml
View File

@ -2,7 +2,7 @@
## You can find it and the values you can provide and modify, at https://github.com/bjw-s/helm-charts/tree/a081de53024d8328d1ae9ff7e4f6bc500b0f3a29/charts/library/common
## Here's the link to the values.yaml file: https://github.com/bjw-s/helm-charts/blob/a081de53024d8328d1ae9ff7e4f6bc500b0f3a29/charts/library/common/values.yaml
## Refer there for more detail about the supported values.
## Any values that you find in the above `values.yaml` can be provided to this chart and are then rendered.
## Any values that you find in the above `values.yaml` can be provided to this chart and are then rendered.
image:
tag: 0.21.0
perfectra1n marked this conversation as resolved Outdated
konrad commented 2023-10-04 16:10:36 +00:00
Outdated
Review
Copy Link

Is there a reason we're using env here and not the config directly?

We should still be able to configure Vikunja as it can be done currently: https://kolaente.dev/vikunja/helm-chart/src/branch/main/values.yaml#L142

There are things that can't be configured via env like openid providers.

Is there a reason we're using env here and not the config directly? We should still be able to configure Vikunja as it can be done currently: https://kolaente.dev/vikunja/helm-chart/src/branch/main/values.yaml#L142 There are things that can't be configured via env like openid providers.
perfectra1n commented 2023-10-04 16:56:40 +00:00
Outdated
Review
Copy Link

Ah, didn't know that. I thought everything was configurable via env variables (which I've always found easier to manage), but I'll go ahead and use the config instead.

Ah, didn't know that. I thought everything was configurable via `env` variables (which I've always found easier to manage), but I'll go ahead and use the `config` instead.
@ -17,8 +17,8 @@ api:
repository: vikunja/api
pullPolicy: IfNotPresent
persistence:
# This is your Vikunja data will live, you can either let
# the chart create a new PVC for you or provide an existing one.
# This is your Vikunja data will live, you can either let
konrad marked this conversation as resolved Outdated
konrad commented 2023-10-10 16:39:43 +00:00
Outdated
Review
Copy Link

Doesn't this need a link to the docs with the default config?

Doesn't this need a link to the docs with the default config?
perfectra1n commented 2023-10-10 22:42:31 +00:00
Outdated
Review
Copy Link

fixed

d8500214e9

fixed https://kolaente.dev/vikunja/helm-chart/commit/d8500214e98def13755bad78e31e9b2e39404df1
# the chart create a new PVC for you or provide an existing one.
data:
enabled: true
# existingClaim: # your-claim
@ -42,7 +42,7 @@ api:
config:
enabled: true
data:
config.yml:
config.yml: |
# Vikunja needs to know the frontend URL for password reset emails.
# So you might need to provide its value, if you're not using an ingress.
# service:
@ -51,11 +51,11 @@ api:
database:
# You should provide your own secret outside of this helm-chart and use `postgresql.global.postgresql.auth.existingSecret` to provide credentials to the postgresql instance (https://github.com/bitnami/charts/blob/5ff8ad5f3c754e3c2423d6abf46f522e8abe0410/bitnami/postgresql/values.yaml#L35-L39)
# To utilize a secret in this configMap, you can do something like the following: https://github.com/bjw-s/helm-charts/blob/a081de53024d8328d1ae9ff7e4f6bc500b0f3a29/charts/library/common/values.yaml#L141-L145
type: 'postgres'
type: postgres
user: "{{ .Values.postgresql.global.postgresql.auth.username }}"
password: "{{ .Values.postgresql.global.postgresql.auth.password }}"
database: "{{ .Values.postgresql.global.postgresql.auth.database }}"
host: '{{ .Release.Name }}-postgresql'
host: "{{ .Release.Name }}-postgresql"
typesense:
# Typesense will only work if it is enabled below (typesense.enabled).
konrad marked this conversation as resolved Outdated
konrad commented 2023-10-10 16:40:52 +00:00
Outdated
Review
Copy Link

But the default value for this one is the one defined in the ingress, why define it here again?

But the default value for this one is the one defined in the ingress, why define it here again?
perfectra1n commented 2023-10-10 22:36:57 +00:00
Outdated
Review
Copy Link

Fair, forgot to use the ingress value for that variable as well. I went ahead and fixed it. I also included a comment to to the user incase they aren't using an ingress resource (I was even using a Service behind a central Nginx until recently)

fixed!

Fair, forgot to use the `ingress` value for that variable as well. I went ahead and fixed it. I also included a comment to to the user incase they aren't using an `ingress` resource (I was even using a `Service` behind a central Nginx until recently) fixed!
perfectra1n commented 2023-10-10 22:41:34 +00:00
Outdated
Review
Copy Link

9cd4680e70 and c601e5e449

https://kolaente.dev/vikunja/helm-chart/commit/9cd4680e707c57d06e718f8d1e6f524408965a32 and https://kolaente.dev/vikunja/helm-chart/commit/c601e5e449523ffb7feb7d35ca72389075769d9c
url: '{{ printf "%s-typesense" .Release.Name }}'
@ -80,7 +80,7 @@ frontend:
service:
main:
type: ClusterIP
# https://github.com/bjw-s/helm-charts/blob/a081de53024d8328d1ae9ff7e4f6bc500b0f3a29/charts/library/common/values.yaml#L393-L436
ingress:
main:
@ -97,13 +97,12 @@ frontend:
# If you've used the "built-in" ingress in the api section, you don't need to specify VIKUNJA_API_URL as an environment variable here.
# If you've used something else, you'll need to provide the URL to the API here.
# env:
# VIKUNJA_API_URL: http://vikunja.local/api
# VIKUNJA_API_URL: http://vikunja.local/api
##########################
# END VIKUNJA COMPONENTS #
##########################
# Optional Dependencies
postgresql:
enabled: true