vikunja/helm-chart
2
2
Fork 5
Code Issues 7 Pull Requests 1 Packages Projects Releases 1 Wiki Activity

Update security context to allow frontend pod to start #6

Merged
konrad merged 2 commits from r1cebank/helm-chart:main into main 2023-05-04 21:39:43 +00:00
Conversation 5 Commits 2 Files Changed 3 +7 -5
3 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Chart.yaml
View File

@ -10,7 +10,7 @@ description: |-
the high alpine areas of the Andes and a relative of the llama. the high alpine areas of the Andes and a relative of the llama.
annotations: annotations:
category: TaskTracker category: TaskTracker
version: 0.1.3 version: 0.1.4
appVersion: 0.20.4 appVersion: 0.20.4
kubeVersion: ">= 1.19" kubeVersion: ">= 1.19"
dependencies: dependencies:

2
README.md
View File

@ -61,7 +61,7 @@ api:
config: config:
database: database:
# Use PostgreSQL database anyway # Use PostgreSQL database anyway
type: postgresql type: postgres
vlasov-y marked this conversation as resolved
vlasov-y commented 2023-05-02 09:38:33 +00:00
Review
Copy Link

According to this documentation paragraph , it has to be postgres, not postgresql. @konrad which value is corrent one?

According to [this](https://vikunja.io/docs/config-options/#type) documentation paragraph , it has to be `postgres`, not `postgresql`. @konrad which value is corrent one?
konrad commented 2023-05-02 09:56:39 +00:00
Review
Copy Link

postgres is correct.

`postgres` is correct.
vlasov-y commented 2023-05-02 11:23:35 +00:00
Review
Copy Link

Okay, then this line is to be reverted @r1cebank

Okay, then this line is to be reverted @r1cebank
r1cebank commented 2023-05-02 16:00:56 +00:00
Review
Copy Link

postgres is the correct value, if i use postgresql the api will fail to start saying unknown database type. why it needs to be reverted?

the current documentation is using 'postgresql' which is incorrect, thats why I made the update to correct it

postgres is the correct value, if i use postgresql the api will fail to start saying unknown database type. why it needs to be reverted? the current documentation is using 'postgresql' which is incorrect, thats why I made the update to correct it
vlasov-y commented 2023-05-03 07:31:23 +00:00
Review
Copy Link

Aaa, you are right :) I somewhy misunderstood the diff and thought that you change postgres to postgresql XD Sorry

Aaa, you are right :) I somewhy misunderstood the diff and thought that you change `postgres` to `postgresql` XD Sorry
r1cebank commented 2023-05-03 20:55:24 +00:00
Review
Copy Link

Haha no worries, I was a bit confused thought I missed something 🤣

Haha no worries, I was a bit confused thought I missed something 🤣
envFrom: envFrom:
# Bind env variables from the secret # Bind env variables from the secret
- name: VIKUNJA_DATABASE_USER - name: VIKUNJA_DATABASE_USER

8
values.yaml
View File

@ -39,12 +39,14 @@ frontend:
# fsGroup: 1000 # fsGroup: 1000
securityContext: securityContext:
allowPrivilegeEscalation: false
runAsUser: 101 # nginx
r1cebank marked this conversation as resolved Outdated
vlasov-y commented 2023-05-02 09:38:38 +00:00
Outdated
Review
Copy Link

Change #nginx to # nginx please

Change `#nginx` to `# nginx` please
capabilities: capabilities:
drop: drop:
- ALL - ALL
# readOnlyRootFilesystem: true add:
# runAsNonRoot: true - NET_BIND_SERVICE
# runAsUser: 1000
service: service:
type: ClusterIP type: ClusterIP