vikunja/vikunja
7
43
Fork 73
Code Issues 150 Pull Requests 16 Packages Releases 32 Activity

remove user from all oidc teams if token is empty

Browse Source
This commit is contained in:
viehlieb 2023-02-01 16:35:12 +01:00
parent dbc7cbc53b
commit 7bebb29f7f
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
pkg/modules/auth/openid/openid.go
View File

@ -210,15 +210,12 @@ func HandleCallback(c echo.Context) error {
return handler.HandleHTTPError(err, c)
}
//TODO: fix this error check
// nil is no problem
//find old teams for user through oidc
oldOidcTeams, _ := models.FindAllOidcTeamIDsForUser(s, u.ID)
var oidcTeams []int64
if len(teamData) > 0 {
//find old teams for user through oidc
oldOidcTeams, _ := models.FindAllOidcTeamIDsForUser(s, u.ID)
// check if we have seen these teams before.
// find or create Teams and assign user as teammember.
var oidcTeams []int64
log.Debugf("TeamData is set %v", teamData)
teams, err := GetOrCreateTeamsByOIDCAndNames(s, teamData, u)
if err != nil {
@ -239,8 +236,8 @@ func HandleCallback(c echo.Context) error {
for _, err := range errs {
log.Errorf("Found Error while signing out from teams %v", err)
}
SignOutFromOrDeleteTeamsByID(s, u, notIn(oldOidcTeams, oidcTeams))
}
SignOutFromOrDeleteTeamsByID(s, u, notIn(oldOidcTeams, oidcTeams))
err = s.Commit()
if err != nil {
_ = s.Rollback()