From 86983f50d4338cbffa3622585331b32cf35e0287 Mon Sep 17 00:00:00 2001
From: Christoph Ritzer <chris@cloumail.at>
Date: Sat, 9 Mar 2024 09:01:02 +0000
Subject: [PATCH] fix(migration): Trello checklists (#2140)

Trello checklists are now properly converted to html checklists and put into the description.

Co-authored-by: kolaente <k@knt.li>
Reviewed-on: https://kolaente.dev/vikunja/vikunja/pulls/2140
Reviewed-by: konrad <k@knt.li>
Co-authored-by: Christoph Ritzer <chris@cloumail.at>
Co-committed-by: Christoph Ritzer <chris@cloumail.at>
---
 pkg/modules/migration/trello/trello.go      | 10 +++++-----
 pkg/modules/migration/trello/trello_test.go | 14 ++++++++------
 2 files changed, 13 insertions(+), 11 deletions(-)

diff --git a/pkg/modules/migration/trello/trello.go b/pkg/modules/migration/trello/trello.go
index 0ae4edd8a..676201b90 100644
--- a/pkg/modules/migration/trello/trello.go
+++ b/pkg/modules/migration/trello/trello.go
@@ -248,17 +248,17 @@ func convertTrelloDataToVikunja(trelloData []*trello.Board, token string) (fullV
 
 				// Checklists (as markdown in description)
 				for _, checklist := range card.Checklists {
-					task.Description += "\n\n## " + checklist.Name + "\n"
+					task.Description += "\n\n<h2> " + checklist.Name + "</h2>\n\n" + `<ul data-type="taskList">`
 
 					for _, item := range checklist.CheckItems {
-						task.Description += "\n* "
+						task.Description += "\n"
 						if item.State == "complete" {
-							task.Description += "[x]"
+							task.Description += `<li data-checked="true" data-type="taskItem"><label><input type="checkbox" checked="checked"><span></span></label><div><p>` + item.Name + `</p></div></li>`
 						} else {
-							task.Description += "[ ]"
+							task.Description += `<li data-checked="false" data-type="taskItem"><label><input type="checkbox"><span></span></label><div><p>` + item.Name + `</p></div></li>`
 						}
-						task.Description += " " + item.Name
 					}
+					task.Description += "</ul>"
 				}
 				if len(card.Checklists) > 0 {
 					log.Debugf("[Trello Migration] Converted %d checklists from card %s", len(card.Checklists), card.ID)
diff --git a/pkg/modules/migration/trello/trello_test.go b/pkg/modules/migration/trello/trello_test.go
index 020ab5399..2b4c6af1e 100644
--- a/pkg/modules/migration/trello/trello_test.go
+++ b/pkg/modules/migration/trello/trello_test.go
@@ -249,15 +249,17 @@ func TestConvertTrelloToVikunja(t *testing.T) {
 						Title: "Test Card 2",
 						Description: `
 
-## Checkproject 1
+<h2> Checkproject 1</h2>
 
-* [ ] Pending Task
-* [x] Completed Task
+<ul data-type="taskList">
+<li data-checked="false" data-type="taskItem"><label><input type="checkbox"><span></span></label><div><p>Pending Task</p></div></li>
+<li data-checked="true" data-type="taskItem"><label><input type="checkbox" checked="checked"><span></span></label><div><p>Completed Task</p></div></li></ul>
 
-## Checkproject 2
+<h2> Checkproject 2</h2>
 
-* [ ] Pending Task
-* [ ] Another Pending Task`,
+<ul data-type="taskList">
+<li data-checked="false" data-type="taskItem"><label><input type="checkbox"><span></span></label><div><p>Pending Task</p></div></li>
+<li data-checked="false" data-type="taskItem"><label><input type="checkbox"><span></span></label><div><p>Another Pending Task</p></div></li></ul>`,
 						BucketID:       1,
 						KanbanPosition: 124,
 					},