From f6437c81da73b7e3406c28b9bd7b201e376f15c3 Mon Sep 17 00:00:00 2001
From: Dominik Pschenitschni <dpschen@noreply.kolaente.de>
Date: Fri, 2 Sep 2022 15:13:32 +0000
Subject: [PATCH] feat: list settings edit script setup (#1988)

Co-authored-by: Dominik Pschenitschni <mail@celement.de>
Reviewed-on: https://kolaente.dev/vikunja/frontend/pulls/1988
Reviewed-by: konrad <k@knt.li>
Co-authored-by: Dominik Pschenitschni <dpschen@noreply.kolaente.de>
Co-committed-by: Dominik Pschenitschni <dpschen@noreply.kolaente.de>
---
 src/composables/useList.ts       | 37 ++++++++++++++
 src/router/index.ts              |  3 ++
 src/views/list/settings/edit.vue | 82 +++++++++++++++-----------------
 3 files changed, 78 insertions(+), 44 deletions(-)
 create mode 100644 src/composables/useList.ts

diff --git a/src/composables/useList.ts b/src/composables/useList.ts
new file mode 100644
index 000000000..6db3ad1d5
--- /dev/null
+++ b/src/composables/useList.ts
@@ -0,0 +1,37 @@
+import {watch, reactive, shallowReactive, unref, toRefs, readonly} from 'vue'
+import type {MaybeRef} from '@vueuse/core'
+import {useStore} from 'vuex'
+
+import ListService from '@/services/list'
+import ListModel from '@/models/list'
+import { success } from '@/message'
+import {useI18n} from 'vue-i18n'
+
+export function useList(listId: MaybeRef<ListModel['id']>) {
+	const listService = shallowReactive(new ListService())
+	const {loading: isLoading} = toRefs(listService)
+	const list : ListModel = reactive(new ListModel({}))
+	const {t} = useI18n()
+
+	watch(
+		() => unref(listId),
+		async (listId) => {
+			const loadedList = await listService.get(new ListModel({id: listId}))
+			Object.assign(list, loadedList)
+		},
+		{immediate: true},
+	)
+
+
+	const store = useStore()
+	async function save() {
+		await store.dispatch('lists/updateList', list)
+		success({message: t('list.edit.success')})
+	}
+
+	return {
+		isLoading: readonly(isLoading),
+		list,
+		save,
+	}
+}
\ No newline at end of file
diff --git a/src/router/index.ts b/src/router/index.ts
index 01f9c6ca2..25c6b9a64 100644
--- a/src/router/index.ts
+++ b/src/router/index.ts
@@ -3,6 +3,8 @@ import type { RouteLocation } from 'vue-router'
 import {saveLastVisited} from '@/helpers/saveLastVisited'
 import {store} from '@/store'
 
+import type ListModel from '@/models/list'
+
 import {saveListView, getListView} from '@/helpers/saveListView'
 import {parseDateOrString} from '@/helpers/time/parseDateOrString'
 import {getNextWeekDate} from '@/helpers/time/getNextWeekDate'
@@ -273,6 +275,7 @@ const router = createRouter({
 			path: '/lists/:listId/settings/edit',
 			name: 'list.settings.edit',
 			component: ListSettingEdit,
+			props: route => ({ listId: parseInt(route.params.listId as ListModel['id']) }),
 			meta: {
 				showAsModal: true,
 			},
diff --git a/src/views/list/settings/edit.vue b/src/views/list/settings/edit.vue
index d516702c9..67055e442 100644
--- a/src/views/list/settings/edit.vue
+++ b/src/views/list/settings/edit.vue
@@ -5,14 +5,14 @@
 		:primary-label="$t('misc.save')"
 		@primary="save"
 		:tertiary="$t('misc.delete')"
-		@tertiary="$router.push({ name: 'list.list.settings.delete', params: { id: $route.params.listId } })"
+		@tertiary="$router.push({ name: 'list.settings.delete', params: { id: listId } })"
 	>
 		<div class="field">
 			<label class="label" for="title">{{ $t('list.title') }}</label>
 			<div class="control">
 				<input
-					:class="{ 'disabled': listService.loading}"
-					:disabled="listService.loading || undefined"
+					:class="{ 'disabled': isLoading}"
+					:disabled="isLoading || undefined"
 					@keyup.enter="save"
 					class="input"
 					id="title"
@@ -31,8 +31,8 @@
 			</label>
 			<div class="control">
 				<input
-					:class="{ 'disabled': listService.loading}"
-					:disabled="listService.loading ? true : null"
+					:class="{ 'disabled': isLoading}"
+					:disabled="isLoading || undefined"
 					@keyup.enter="save"
 					class="input"
 					id="identifier"
@@ -46,8 +46,8 @@
 			<label class="label" for="listdescription">{{ $t('list.edit.description') }}</label>
 			<div class="control">
 				<editor
-					:class="{ 'disabled': listService.loading}"
-					:disabled="listService.loading"
+					:class="{ 'disabled': isLoading}"
+					:disabled="isLoading"
 					:previewIsDefault="false"
 					id="listdescription"
 					:placeholder="$t('list.edit.descriptionPlaceholder')"
@@ -66,50 +66,44 @@
 </template>
 
 <script lang="ts">
-import {defineComponent} from 'vue'
+export default { name: 'list-setting-edit' }
+</script>
 
-import AsyncEditor from '@/components/input/AsyncEditor'
+<script setup lang="ts">
+import type {PropType} from 'vue'
+import {useRouter} from 'vue-router'
+import {useStore} from 'vuex'
+import {useI18n} from 'vue-i18n'
 
-import ListModel from '@/models/list'
-import ListService from '@/services/list'
+import Editor from '@/components/input/AsyncEditor'
 import ColorPicker from '@/components/input/colorPicker.vue'
-import {CURRENT_LIST} from '@/store/mutation-types'
 import CreateEdit from '@/components/misc/create-edit.vue'
 
-export default defineComponent({
-	name: 'list-setting-edit',
-	data() {
-		return {
-			list: ListModel,
-			listService: new ListService(),
-		}
-	},
-	components: {
-		CreateEdit,
-		ColorPicker,
-		editor: AsyncEditor,
-	},
-	watch: {
-		'$route.params.listId': {
-			handler: 'loadList',
-			immediate: true,
-		},
-	},
-	methods: {
-		async loadList() {
-			const list = new ListModel({id: this.$route.params.listId})
+import {CURRENT_LIST} from '@/store/mutation-types'
+import type ListModel from '@/models/list'
 
-			const loadedList = await this.listService.get(list)
-			this.list = { ...loadedList }
-		},
+import { useList } from '@/composables/useList'
+import { useTitle } from '@/composables/useTitle'
 
-		async save() {
-			await this.$store.dispatch('lists/updateList', this.list)
-			await this.$store.dispatch(CURRENT_LIST, {list: this.list})
-			this.setTitle(this.$t('list.edit.title', {list: this.list.title}))
-			this.$message.success({message: this.$t('list.edit.success')})
-			this.$router.back()
-		},
+const props = defineProps({
+	listId: {
+		type: Number as PropType<ListModel['id']>,
+		required: true,
 	},
 })
+
+const router = useRouter()
+const store = useStore()
+
+const {t} = useI18n()
+
+const {list, save: saveList, isLoading} = useList(props.listId)
+
+useTitle(() => list?.title ? t('list.edit.title', {list: list.title}) : '')
+
+async function save() {
+	await saveList()
+	await store.dispatch(CURRENT_LIST, {list})
+	router.back()
+}
 </script>