perf: useNow is a resource hog #1434

New Issue

WofWca · 2023-03-16T13:28:41Z

WofWca commented

2023-03-16 13:28:41 +00:00

One of the places it's used in:

9b050846a4/src/components/home/Logo.vue (L8-L9)

While nothing is happening, it takes a considerable portion of CPU time.

Consider providing the interval option.

One of the places it's used in: https://kolaente.dev/vikunja/frontend/src/commit/9b050846a41a3d05872cf3ca3ca1f06688084501/src/components/home/Logo.vue#L8-L9 While nothing is happening, it takes a considerable portion of CPU time. ![image](/attachments/20162669-0c5c-44a0-8ca3-30da5732b257) Consider providing the `interval` option.

image.png

3.5 KiB

WofWca commented

2023-03-16 14:23:18 +00:00

Sorry, I meant to create it in the frontend repo.

Sorry, I meant to create it in the `frontend` repo.

konrad referenced this issue from vikunja/frontend

2023-03-16 18:25:46 +00:00

fix: add interval to uses of useNow so that it uses less resources #3255

konrad commented

2023-03-16 18:27:33 +00:00

PR is up: vikunja/frontend#3255

PR is up: https://kolaente.dev/vikunja/frontend/pulls/3255

dpschen commented

2023-03-17 16:01:21 +00:00

@WofWca May I ask, how you exactly got to the screenshot?

WofWca commented

2023-03-17 16:20:17 +00:00

Open https://try.vikunja.io/projects/13/list in a Chromium browser
Open the dev tools
"Performance" tab
Start recording
Do nothing for 25 seconds
Stop recording
Open the "summary" tab below

1. Open https://try.vikunja.io/projects/13/list in a Chromium browser 2. Open the dev tools 3. "Performance" tab 4. Start recording 5. Do nothing for 25 seconds 6. Stop recording 7. Open the "summary" tab below

dpschen commented

2023-03-24 23:31:08 +00:00

PR is merged